<rdar://problem/14393032>

DumpValueObject() 2.0

This checkin restores pre-Xcode5 functionality to the "po" (expr -O) command:
- expr now has a new --description-verbosity (-v) argument, which takes either compact or full as a value (-v is the same as -vfull)
 When the full mode is on, "po" will show the extended output with type name, persistent variable name and value, as in
(lldb) expr -O -v -- foo
(id) $0 = 0x000000010010baf0 {
    1 = 2;
    2 = 3;
}

 When -v is omitted, or -vcompact is passed, the Xcode5-style output will be shown, as in
(lldb) expr -O -- foo
{
    1 = 2;
    2 = 3;
}

- for a non-ObjectiveC object, LLDB will still try to retrieve a summary and/or value to display
(lldb) po 5
5
-v also works in this mode
(lldb) expr -O -vfull -- 5
(int) $4 = 5 

On top of that, this is a major refactoring of the ValueObject printing code. The functionality is now factored into a ValueObjectPrinter class for easier maintenance in the future
DumpValueObject() was turned into an instance method ValueObject::Dump() which simply calls through to the printer code, Dump_Impl has been removed

Test case to follow

llvm-svn: 191694

1 files changed, 4 insertions, 4 deletions

diff --git a/lldb/test/lang/cpp/namespace/TestNamespace.py b/lldb/test/lang/cpp/namespace/TestNamespace.py
index 52c4ad00478..a3b6366275d 100644
--- a/lldb/test/lang/cpp/namespace/TestNamespace.py
+++ b/lldb/test/lang/cpp/namespace/TestNamespace.py
@@ -83,12 +83,12 @@ class NamespaceTestCase(TestBase):
         # 'frame variable' with fully qualified name 'A::B::j' should work.
         self.expect("frame variable A::B::j", VARIABLES_DISPLAYED_CORRECTLY,
             startstr = '(int) A::B::j = 4',
-            patterns = [' = 4$'])
+            patterns = [' = 4'])
 
         # So should the anonymous namespace case.
         self.expect("frame variable '(anonymous namespace)::i'", VARIABLES_DISPLAYED_CORRECTLY,
             startstr = '(int) (anonymous namespace)::i = 3',
-            patterns = [' = 3$'])
+            patterns = [' = 3'])
 
         # rdar://problem/8660275
         # test/namespace: 'expression -- i+j' not working
@@ -103,9 +103,9 @@ class NamespaceTestCase(TestBase):
         # rdar://problem/8668674
         # expression command with fully qualified namespace for a variable does not work
         self.expect("expression -- ::i", VARIABLES_DISPLAYED_CORRECTLY,
-            patterns = [' = 3$'])
+            patterns = [' = 3'])
         self.expect("expression -- A::B::j", VARIABLES_DISPLAYED_CORRECTLY,
-            patterns = [' = 4$'])
+            patterns = [' = 4'])
 
         # expression command with function in anonymous namespace
         self.expect("expression -- myanonfunc(3)",