diff options
| author | Greg Clayton <gclayton@apple.com> | 2015-05-23 03:54:53 +0000 |
|---|---|---|
| committer | Greg Clayton <gclayton@apple.com> | 2015-05-23 03:54:53 +0000 |
| commit | 5df78fa35b75e51014884ec5eae7fc0ff83f7dd8 (patch) | |
| tree | 21f8562ce446d54b008ec2b6334c359bdbd4b333 /lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp | |
| parent | ac60f4594fb8e7d249db05f5b3a89533e11a92be (diff) | |
| download | bcm5719-llvm-5df78fa35b75e51014884ec5eae7fc0ff83f7dd8.tar.gz bcm5719-llvm-5df78fa35b75e51014884ec5eae7fc0ff83f7dd8.zip | |
Did some cleanup to stop us from leaking Pipe file descriptors.
The main issue was the Communication::Disconnect() was calling its Connection::Disconnect() but this wouldn't release the pipes that the ConnectionFileDescriptor was using. We also have someone that is holding a strong reference to the Process so that when you re-run, target replaces its m_process_sp, but it doesn't get destructed because someone has a strong reference to it. I need to track that down. But, even if we have a strong reference to the a process that is outstanding, we need to call Process::Finalize() to have it release as much of its resources as possible to avoid memory bloat.
Removed the ProcessGDBRemote::SetExitStatus() override and replaced it with ProcessGDBRemote::DidExit().
Now we aren't leaking file descriptors and the stand alone test suite should run much better.
llvm-svn: 238089
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp')
0 files changed, 0 insertions, 0 deletions
