diff options
| author | Pavel Labath <labath@google.com> | 2017-10-17 15:52:16 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-10-17 15:52:16 +0000 |
| commit | a5be48b3e0dd9c331ab50e4cbc7bf2b805ffba73 (patch) | |
| tree | 195bc6a7cc1b1d89ea197968c824aa34287e73be /lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h | |
| parent | 6ed5c91422e42ff78a38a506069b99c10084cfdd (diff) | |
| download | bcm5719-llvm-a5be48b3e0dd9c331ab50e4cbc7bf2b805ffba73.tar.gz bcm5719-llvm-a5be48b3e0dd9c331ab50e4cbc7bf2b805ffba73.zip | |
Remove shared_pointer from NativeThreadProtocol
Summary:
The NativeThread class is useless without the containing process (and in
some places it is already assuming the process is always around). This
makes it clear that the NativeProcessProtocol is the object owning the
threads, and makes the destruction order deterministic (first threads,
then process). The NativeProcess is the only thing holding a thread
unique_ptr, and methods that used to hand out thread shared pointers now
return raw pointers or references.
Reviewers: krytarowski, eugene
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D35618
llvm-svn: 316007
Diffstat (limited to 'lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h')
| -rw-r--r-- | lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h b/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h index 2cbd5e30ab2..5ecf4623572 100644 --- a/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h +++ b/lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h @@ -121,7 +121,7 @@ private: bool HasThreadNoLock(lldb::tid_t thread_id); - NativeThreadNetBSDSP AddThread(lldb::tid_t thread_id); + NativeThreadNetBSD &AddThread(lldb::tid_t thread_id); void MonitorCallback(lldb::pid_t pid, int signal); void MonitorExited(lldb::pid_t pid, WaitStatus status); |
