Fix more functions in Args to use StringRef.

This patch also marks the const char* versions as =delete to prevent
their use.  This has the potential to cause build breakages on some
platforms which I can't compile.  I have tested on Windows, Linux,
and OSX.  Best practices for fixing broken callsites are outlined in
Args.h in a comment above the deleted function declarations.

Eventually we can remove these =delete declarations, but for now they
are important to make sure that all implicit conversions from
const char * are manually audited to make sure that they do not invoke a
conversion from nullptr.

llvm-svn: 281919

1 files changed, 3 insertions, 2 deletions

diff --git a/lldb/source/Commands/CommandObjectLog.cpp b/lldb/source/Commands/CommandObjectLog.cpp
index e4c5a8656ed..85134442213 100644
--- a/lldb/source/Commands/CommandObjectLog.cpp
+++ b/lldb/source/Commands/CommandObjectLog.cpp
@@ -387,8 +387,9 @@ protected:
       }
       if (strcasecmp(sub_command, "increment") == 0) {
         bool success;
-        bool increment =
-            Args::StringToBoolean(args.GetArgumentAtIndex(1), false, &success);
+        bool increment = Args::StringToBoolean(
+            llvm::StringRef::withNullAsEmpty(args.GetArgumentAtIndex(1)), false,
+            &success);
         if (success) {
           Timer::SetQuiet(!increment);
           result.SetStatus(eReturnStatusSuccessFinishNoResult);