diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-12-31 17:19:34 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-12-31 17:19:34 +0000 |
| commit | 54b435ec3ce4fdf8365ba3337cb2cb9176930e59 (patch) | |
| tree | e08db7459971a11ad2882263a6e2d5138163a4a1 /lld/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp | |
| parent | 5691eb5ee772740a140938b1c3d7f82c8b2e53c8 (diff) | |
| download | bcm5719-llvm-54b435ec3ce4fdf8365ba3337cb2cb9176930e59.tar.gz bcm5719-llvm-54b435ec3ce4fdf8365ba3337cb2cb9176930e59.zip | |
Add r224985 back with a fix.
The issues was that AArch64 has additional restrictions on when local
relocations can be used. We have to take those into consideration when
deciding to put a L symbol in the symbol table or not.
Original message:
Remove doesSectionRequireSymbols.
In an assembly expression like
bar:
.long L0 + 1
the intended semantics is that bar will contain a pointer one byte past L0.
In sections that are merged by content (strings, 4 byte constants, etc), a
single position in the section doesn't give the linker enough information.
For example, it would not be able to tell a relocation must point to the
end of a string, since that would look just like the start of the next.
The solution used in ELF to use relocation with symbols if there is a non-zero
addend.
In MachO before this patch we would just keep all symbols in some sections.
This would miss some cases (only cstrings on x86_64 were implemented) and was
inefficient since most relocations have an addend of 0 and can be represented
without the symbol.
This patch implements the non-zero addend logic for MachO too.
llvm-svn: 225048
Diffstat (limited to 'lld/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp')
0 files changed, 0 insertions, 0 deletions

