COFF: Allow forward reference for weak externals

Previously, weak external symbols could reference only symbols that
appeared before them. Although that covers almost all use cases
of weak externals, there are object files out there which contains
weak externals that have forward references.

This patch supports such weak externals.

llvm-svn: 245258

1 files changed, 1 insertions, 1 deletions

diff --git a/lld/COFF/Symbols.cpp b/lld/COFF/Symbols.cpp
index c0324fdb3be..d732d76cfb0 100644
--- a/lld/COFF/Symbols.cpp
+++ b/lld/COFF/Symbols.cpp
@@ -132,7 +132,7 @@ int SymbolBody::compare(SymbolBody *Other) {
     auto *RHS = cast<Undefined>(Other);
     // Tie if both undefined symbols have different weak aliases.
     if (LHS->WeakAlias && RHS->WeakAlias) {
-      if (LHS->WeakAlias->repl() != RHS->WeakAlias->repl())
+      if (LHS->WeakAlias->getName() != RHS->WeakAlias->getName())
         return 0;
       return uintptr_t(LHS) < uintptr_t(RHS) ? 1 : -1;
     }