diff options
| author | Sunil Srivastava <sunil_srivastava@playstation.sony.com> | 2018-05-15 18:28:42 +0000 |
|---|---|---|
| committer | Sunil Srivastava <sunil_srivastava@playstation.sony.com> | 2018-05-15 18:28:42 +0000 |
| commit | 74f8d86f6bec09d083abf4755b476df7606bcb59 (patch) | |
| tree | 4d96da0917d1c116149667fdcd8469f8cfbe1f85 /clang/test | |
| parent | df4fb5a87c1799ae515346ad56a88ec378f1f5ae (diff) | |
| download | bcm5719-llvm-74f8d86f6bec09d083abf4755b476df7606bcb59.tar.gz bcm5719-llvm-74f8d86f6bec09d083abf4755b476df7606bcb59.zip | |
Fixed some rtti-options tests.
Certain tests in rtti-options.cpp are not really testing anything because they are testing for the absence of -frtti option to the cc1 process. Since the cc1 process does not take -frtti option, these tests are passing tautologically.
The RTTI mode is enabled by default in cc1, and -fno-rtti disables it. Therefore the correct way to check for enabling of RTTI is to check for the absence of -fno-rtti to cc1, and the correct way to check for disabling of RTTI is to check for the presence of -fno-rtti to cc1.
This patch fixes those tests.
Differential Revision: https://reviews.llvm.org/D46836
llvm-svn: 332384
Diffstat (limited to 'clang/test')
| -rw-r--r-- | clang/test/Driver/rtti-options.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/clang/test/Driver/rtti-options.cpp b/clang/test/Driver/rtti-options.cpp index 954e00dfda9..131c858fb37 100644 --- a/clang/test/Driver/rtti-options.cpp +++ b/clang/test/Driver/rtti-options.cpp @@ -5,8 +5,8 @@ // Special cases: -fcxx-exceptions in C code should warn about unused arguments // We should also not have any rtti-related arguments -// RUN: %clang -x c -### -target x86_64-scei-ps4 -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI -check-prefix=CHECK-NO-RTTI %s -// RUN: %clang -x c -### -target x86_64-unknown-unknown -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI -check-prefix=CHECK-NO-RTTI %s +// RUN: %clang -x c -### -target x86_64-scei-ps4 -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI %s +// RUN: %clang -x c -### -target x86_64-unknown-unknown -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED -check-prefix=CHECK-RTTI %s // Make sure we keep the last -frtti/-fno-rtti argument // RUN: %clang -### -c -fno-rtti -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI %s @@ -56,6 +56,6 @@ // CHECK-EXC-ERROR: invalid argument '-fno-rtti' not allowed with '-fexceptions' // CHECK-EXC-ERROR-CXX: invalid argument '-fno-rtti' not allowed with '-fcxx-exceptions' // CHECK-RTTI-NOT: "-fno-rtti" -// CHECK-NO-RTTI-NOT: "-frtti" +// CHECK-NO-RTTI: "-fno-rtti" // CHECK-OK-NOT: {{warning:|error:}} |
