diff options
| author | George Karpenkov <ekarpenkov@apple.com> | 2018-08-23 00:02:35 +0000 |
|---|---|---|
| committer | George Karpenkov <ekarpenkov@apple.com> | 2018-08-23 00:02:35 +0000 |
| commit | c433011e02d44ed31c20761ce897faea535bec31 (patch) | |
| tree | 84177d1fbbe54b871b60fd8360cfacfdea63d0ab /clang/test/Analysis/cstring-syntax.c | |
| parent | b45bf3bb8b5fb4a4fe6634a22f64b30428589644 (diff) | |
| download | bcm5719-llvm-c433011e02d44ed31c20761ce897faea535bec31.tar.gz bcm5719-llvm-c433011e02d44ed31c20761ce897faea535bec31.zip | |
Revert "[CStringSyntaxChecker] Check strlcat sizeof check"
This reverts commit 3073790e87378fea9a68fb052185fec9596ef135.
The check is not correct, strlact(dest, "mystr", sizeof(dest)) is fine.
llvm-svn: 340501
Diffstat (limited to 'clang/test/Analysis/cstring-syntax.c')
| -rw-r--r-- | clang/test/Analysis/cstring-syntax.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/clang/test/Analysis/cstring-syntax.c b/clang/test/Analysis/cstring-syntax.c index c6d36940605..fe1253bedba 100644 --- a/clang/test/Analysis/cstring-syntax.c +++ b/clang/test/Analysis/cstring-syntax.c @@ -7,7 +7,6 @@ typedef __SIZE_TYPE__ size_t; char *strncat(char *, const char *, size_t); size_t strlen (const char *s); size_t strlcpy(char *, const char *, size_t); -size_t strlcat(char *, const char *, size_t); void testStrncat(const char *src) { char dest[10]; @@ -34,19 +33,3 @@ void testStrlcpy(const char *src) { strlcpy(dest + 5, src, 5); strlcpy(dest + 5, src, 10); // expected-warning {{The third argument is larger than the size of the input buffer.}} } - -void testStrlcat(const char *src) { - char dest[10]; - size_t badlen = 10; - size_t ulen; - strlcpy(dest, "aaaaa", sizeof("aaaaa") - 1); - strlcat(dest, "bbbb", (sizeof("bbbb") - 1) - sizeof(dest) - 1); - strlcpy(dest, "012345678", sizeof(dest)); - strlcat(dest, "910", sizeof(dest)); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the value <size> - strlen(dest) - 1 or lower}} - strlcpy(dest, "0123456789", sizeof(dest)); - strlcat(dest, "0123456789", badlen); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the value 'badlen' - strlen(dest) - 1 or lower}} - strlcat(dest, "0123456789", badlen - strlen(dest) - 1); - strlcat(dest, src, ulen); - strlcpy(dest, src, 5); - strlcat(dest + 5, src, badlen); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the value 'badlen' - strlen(<destination buffer>) - 1 or lower}} -} |

