diff options
| author | Daniel Sanders <daniel.sanders@imgtec.com> | 2014-08-08 15:47:17 +0000 |
|---|---|---|
| committer | Daniel Sanders <daniel.sanders@imgtec.com> | 2014-08-08 15:47:17 +0000 |
| commit | feb613028bfc7edb371546cd493708fd156b45a3 (patch) | |
| tree | eb72a30064ea3c3d125685c0009436eaa1aac68d /clang/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp | |
| parent | ced70066c24b9f62ad0e4d4c303a6122d7d335f2 (diff) | |
| download | bcm5719-llvm-feb613028bfc7edb371546cd493708fd156b45a3.tar.gz bcm5719-llvm-feb613028bfc7edb371546cd493708fd156b45a3.zip | |
[mips] Invert the abicalls feature bit to be noabicalls so that it's possible for -mno-abicalls to take effect.
Also added the testcase that should have been in r215194.
This behaviour has surprised me a few times now. The problem is that the
generated MipsSubtarget::ParseSubtargetFeatures() contains code like this:
if ((Bits & Mips::FeatureABICalls) != 0) IsABICalls = true;
so '-abicalls' means 'leave it at the default' and '+abicalls' means 'set it to
true'. In this case, (and the similar -modd-spreg case) I'd like the code to be
IsABICalls = (Bits & Mips::FeatureABICalls) != 0;
or possibly:
if ((Bits & Mips::FeatureABICalls) != 0)
IsABICalls = true;
else
IsABICalls = false;
and preferably arrange for 'Bits & Mips::FeatureABICalls' to be true by default
(on some triples).
llvm-svn: 215211
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp')
0 files changed, 0 insertions, 0 deletions

