diff options
author | Chris Lattner <sabre@nondot.org> | 2009-03-29 16:50:03 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-03-29 16:50:03 +0000 |
commit | 5bbb3c8ad9222bd511e75aa93e4c54c7d79c5b16 (patch) | |
tree | 8f94a9454d87e905c6c25f6482dddaf953e4493e /clang/lib/CodeGen/ModuleBuilder.cpp | |
parent | 6c84a5a39481222d18cd5004db76258c6d0cb4fd (diff) | |
download | bcm5719-llvm-5bbb3c8ad9222bd511e75aa93e4c54c7d79c5b16.tar.gz bcm5719-llvm-5bbb3c8ad9222bd511e75aa93e4c54c7d79c5b16.zip |
Push DeclGroup much farther throughout the compiler. Now the various
productions (except the already broken ObjC cases like @class X,Y;) in
the parser that can produce more than one Decl return a DeclGroup instead
of a Decl, etc.
This allows elimination of the Decl::NextDeclarator field, and exposes
various clients that should look at all decls in a group, but which were
only looking at one (such as the dumper, printer, etc). These have been
fixed.
Still TODO:
1) there are some FIXME's in the code about potentially using
DeclGroup for better location info.
2) ParseObjCAtDirectives should return a DeclGroup due to @class etc.
3) I'm not sure what is going on with StmtIterator.cpp, or if it can
be radically simplified now.
4) I put a truly horrible hack in ParseTemplate.cpp.
I plan to bring up #3/4 on the mailing list, but don't plan to tackle
#1/2 in the short term.
llvm-svn: 68002
Diffstat (limited to 'clang/lib/CodeGen/ModuleBuilder.cpp')
-rw-r--r-- | clang/lib/CodeGen/ModuleBuilder.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/clang/lib/CodeGen/ModuleBuilder.cpp b/clang/lib/CodeGen/ModuleBuilder.cpp index d41f1339b09..896464ed5a8 100644 --- a/clang/lib/CodeGen/ModuleBuilder.cpp +++ b/clang/lib/CodeGen/ModuleBuilder.cpp @@ -60,16 +60,16 @@ namespace { *M, *TD, Diags)); } - virtual void HandleTopLevelDecl(Decl *D) { + virtual void HandleTopLevelDecl(DeclGroupRef DG) { // Make sure to emit all elements of a Decl. - for (; D; D = D->getNextDeclarator()) - Builder->EmitTopLevelDecl(D); + for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) + Builder->EmitTopLevelDecl(*I); } /// HandleTagDeclDefinition - This callback is invoked each time a TagDecl - /// (e.g. struct, union, enum, class) is completed. This allows the client to - /// hack on the type, which can occur at any point in the file (because these - /// can be defined in declspecs). + /// to (e.g. struct, union, enum, class) is completed. This allows the + /// client hack on the type, which can occur at any point in the file + /// (because these can be defined in declspecs). virtual void HandleTagDeclDefinition(TagDecl *D) { Builder->UpdateCompletedType(D); } |