diff options
| author | Kadir Cetinkaya <kadircet@google.com> | 2020-01-15 18:09:51 +0100 |
|---|---|---|
| committer | Kadir Cetinkaya <kadircet@google.com> | 2020-01-27 16:35:12 +0100 |
| commit | 7350a0429cc77947abba1591839a7a652af66623 (patch) | |
| tree | d3d12a65c26a1d88e83b0ecae5f311b2f1666c89 /clang-tools-extra/clangd | |
| parent | 1f448807c2ef24ffe0fde19fdd2fc46556436a5c (diff) | |
| download | bcm5719-llvm-7350a0429cc77947abba1591839a7a652af66623.tar.gz bcm5719-llvm-7350a0429cc77947abba1591839a7a652af66623.zip | |
[clangd] Dont display `<unknown>` kinds in hover board
Summary:
Currently when hovering over an `auto` or `decltype` that resolve to a
builtin-type, clangd would display `<unknown>` as the kind of the symbol.
Drop that to make rendering nicer.
Reviewers: usaxena95
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72777
(cherry picked from commit b08e8353a89f682861ef947fdb6e229b3de2e37d)
Diffstat (limited to 'clang-tools-extra/clangd')
| -rw-r--r-- | clang-tools-extra/clangd/Hover.cpp | 3 | ||||
| -rw-r--r-- | clang-tools-extra/clangd/unittests/HoverTests.cpp | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp index 118d58591d2..0833a46f088 100644 --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -522,7 +522,8 @@ markup::Document HoverInfo::present() const { // level 1 and 2 headers in a huge font, see // https://github.com/microsoft/vscode/issues/88417 for details. markup::Paragraph &Header = Output.addHeading(3); - Header.appendText(index::getSymbolKindString(Kind)); + if (Kind != index::SymbolKind::Unknown) + Header.appendText(index::getSymbolKindString(Kind)); assert(!Name.empty() && "hover triggered on a nameless symbol"); Header.appendCode(Name); diff --git a/clang-tools-extra/clangd/unittests/HoverTests.cpp b/clang-tools-extra/clangd/unittests/HoverTests.cpp index 385c064a9dc..65d5e4a6c21 100644 --- a/clang-tools-extra/clangd/unittests/HoverTests.cpp +++ b/clang-tools-extra/clangd/unittests/HoverTests.cpp @@ -1655,7 +1655,7 @@ TEST(Hover, Present) { HI.Kind = index::SymbolKind::Unknown; HI.Name = "X"; }, - R"(<unknown> X)", + R"(X)", }, { [](HoverInfo &HI) { |
