diff options
| author | Haojian Wu <hokein.wu@gmail.com> | 2019-11-15 16:24:19 +0100 |
|---|---|---|
| committer | Haojian Wu <hokein.wu@gmail.com> | 2019-11-15 16:28:10 +0100 |
| commit | b221c9d09dd12bde75f00f3541c8f344925d4d59 (patch) | |
| tree | b3275c30e7b7a4196ae87c525f9d40e98ec60140 /clang-tools-extra/clangd/index/SymbolCollector.cpp | |
| parent | 509efe5d8edee5637b26fcb645978325de0a7283 (diff) | |
| download | bcm5719-llvm-b221c9d09dd12bde75f00f3541c8f344925d4d59.tar.gz bcm5719-llvm-b221c9d09dd12bde75f00f3541c8f344925d4d59.zip | |
[clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.
Summary:
The helper is more correct to detect header file, this would fix our
issues caused by false positive before.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: merge_guards_bot, ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70299
Diffstat (limited to 'clang-tools-extra/clangd/index/SymbolCollector.cpp')
| -rw-r--r-- | clang-tools-extra/clangd/index/SymbolCollector.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp b/clang-tools-extra/clangd/index/SymbolCollector.cpp index 06fe854b2e0..00adbd84fd6 100644 --- a/clang-tools-extra/clangd/index/SymbolCollector.cpp +++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp @@ -304,7 +304,8 @@ bool SymbolCollector::handleDeclOccurence( // it's main-file only. bool IsMainFileOnly = SM.isWrittenInMainFile(SM.getExpansionLoc(ND->getBeginLoc())) && - !ASTCtx->getLangOpts().IsHeaderFile; + !isHeaderFile(SM.getFileEntryForID(SM.getMainFileID())->getName(), + ASTCtx->getLangOpts()); // In C, printf is a redecl of an implicit builtin! So check OrigD instead. if (ASTNode.OrigD->isImplicit() || !shouldCollectSymbol(*ND, *ASTCtx, Opts, IsMainFileOnly)) |
