summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clangd/CodeComplete.h
diff options
context:
space:
mode:
authorIlya Biryukov <ibiryukov@google.com>2018-05-16 12:32:44 +0000
committerIlya Biryukov <ibiryukov@google.com>2018-05-16 12:32:44 +0000
commit43714504a81f1b588622f03186b3564d7a71cdf6 (patch)
treeb5109bb4cfe159e896f6c8f5dbe939f1246e295e /clang-tools-extra/clangd/CodeComplete.h
parent1ff7c32fc91c607b690d4bb9cf42f406be8dde68 (diff)
downloadbcm5719-llvm-43714504a81f1b588622f03186b3564d7a71cdf6.tar.gz
bcm5719-llvm-43714504a81f1b588622f03186b3564d7a71cdf6.zip
[clangd] Retrieve minimally formatted comment text in completion.
Summary: Previous implementation used to extract brief text from doxygen comments. Brief text parsing slows down completion and is not suited for non-doxygen comments. This commit switches to providing comments that mimic the ones originally written in the source code, doing minimal reindenting and removing the comments markers to make the output more user-friendly. It means we lose support for doxygen-specific features, e.g. extracting brief text, but provide useful results for non-doxygen comments. Switching the doxygen support back is an option, but I suggest to see whether the current approach gives more useful results. Reviewers: sammccall, hokein, ioeric Reviewed By: sammccall Subscribers: klimek, MaskRay, jkorous, cfe-commits Differential Revision: https://reviews.llvm.org/D45999 llvm-svn: 332459
Diffstat (limited to 'clang-tools-extra/clangd/CodeComplete.h')
-rw-r--r--clang-tools-extra/clangd/CodeComplete.h6
1 files changed, 2 insertions, 4 deletions
diff --git a/clang-tools-extra/clangd/CodeComplete.h b/clang-tools-extra/clangd/CodeComplete.h
index e89a660afd9..4d0ef75141c 100644
--- a/clang-tools-extra/clangd/CodeComplete.h
+++ b/clang-tools-extra/clangd/CodeComplete.h
@@ -45,10 +45,8 @@ struct CodeCompleteOptions {
/// Add macros to code completion results.
bool IncludeMacros = true;
- /// Add brief comments to completion items, if available.
- /// FIXME(ibiryukov): it looks like turning this option on significantly slows
- /// down completion, investigate if it can be made faster.
- bool IncludeBriefComments = true;
+ /// Add comments to code completion results, if available.
+ bool IncludeComments = true;
/// Include results that are not legal completions in the current context.
/// For example, private members are usually inaccessible.
OpenPOWER on IntegriCloud