Verify assign operator signatures.

Summary: Warn when the return type of assign operators is not Class&.

Reviewers: alexfh

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D6667

llvm-svn: 228583

1 files changed, 35 insertions, 0 deletions

diff --git a/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.h b/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.h
new file mode 100644
index 00000000000..e5e244a1650
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.h
@@ -0,0 +1,35 @@
+//===--- AssignOperatorSignatureCheck.h - clang-tidy ------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_ASSIGN_OPERATOR_SIGNATURE_CHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_ASSIGN_OPERATOR_SIGNATURE_CHECK_H
+
+#include "../ClangTidy.h"
+
+namespace clang {
+namespace tidy {
+
+/// \brief Finds declarations of assign operators with the wrong return and/or
+///   argument types.
+///
+/// The return type must be \c Class&.
+/// Works with move-assign and assign by value.
+/// Private and deleted operators are ignored.
+class AssignOperatorSignatureCheck : public ClangTidyCheck {
+public:
+  AssignOperatorSignatureCheck(StringRef Name, ClangTidyContext *Context)
+      : ClangTidyCheck(Name, Context) {}
+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+};
+
+} // namespace tidy
+} // namespace clang
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_ASSIGN_OPERATOR_SIGNATURE_CHECK_H