summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRui Ueyama <ruiu@google.com>2017-05-02 02:58:04 +0000
committerRui Ueyama <ruiu@google.com>2017-05-02 02:58:04 +0000
commitdfb1e2a1a148c3d269e2d03e572747425b2dbb53 (patch)
treeb435033b74cc6f4afb80b49ce9102d3fb1854731
parentf13a6904b32ea9c2c2cd51cb8236183a341288ed (diff)
downloadbcm5719-llvm-dfb1e2a1a148c3d269e2d03e572747425b2dbb53.tar.gz
bcm5719-llvm-dfb1e2a1a148c3d269e2d03e572747425b2dbb53.zip
Update commetns.
llvm-svn: 301896
-rw-r--r--lld/ELF/InputFiles.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp
index 9f14adda409..12867bbd071 100644
--- a/lld/ELF/InputFiles.cpp
+++ b/lld/ELF/InputFiles.cpp
@@ -410,9 +410,11 @@ elf::ObjectFile<ELFT>::createInputSection(const Elf_Shdr &Sec,
// Mergeable sections with relocations are tricky because relocations
// need to be taken into account when comparing section contents for
- // merging. The MergeInputSection class currently doesn't care about
- // relocations, and it's unlikely to support it in future because such
- // sections are rare. We simply handle such sections as non-mergeable.
+ // merging. It doesn't worth supporting such mergeable sections because
+ // they are rare and it'd complicates the internal design (we usually
+ // have to determine if two sections are mergeable early in the link
+ // process much before applying relocations). We simply handle mergeable
+ // sections with relocations as non-mergeable.
if (auto *MS = dyn_cast<MergeInputSection>(Target)) {
Target = toRegularSection(MS);
this->Sections[Sec.sh_info] = Target;
OpenPOWER on IntegriCloud