diff options
| author | Zachary Turner <zturner@google.com> | 2017-03-22 00:27:54 +0000 |
|---|---|---|
| committer | Zachary Turner <zturner@google.com> | 2017-03-22 00:27:54 +0000 |
| commit | 90bf36f949c4848a6cc5d4b87b56f3a5149b4273 (patch) | |
| tree | b96de38d2ea3f5bc80a6140ebc327883688f636e | |
| parent | aaedf891019203cec1552b166edb2bf9972b3b14 (diff) | |
| download | bcm5719-llvm-90bf36f949c4848a6cc5d4b87b56f3a5149b4273.tar.gz bcm5719-llvm-90bf36f949c4848a6cc5d4b87b56f3a5149b4273.zip | |
Break the cycle between Host and PluginProcessUtility.
There are only two users of NativeRegisterContextRegisterInfo,
and both are in process plugins. Moving this code from Host
to Plugins/Process/Utility thus makes sense, and as it is the
only dependency from Host -> PluginProcessUtility, it also
breaks this cycle, reducing LLDB's overall cycle count from
45 to 44.
llvm-svn: 298466
| -rw-r--r-- | lldb/source/Host/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h | 2 | ||||
| -rw-r--r-- | lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h | 2 | ||||
| -rw-r--r-- | lldb/source/Plugins/Process/Utility/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.cpp (renamed from lldb/source/Host/common/NativeRegisterContextRegisterInfo.cpp) | 2 | ||||
| -rw-r--r-- | lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h (renamed from lldb/include/lldb/Host/common/NativeRegisterContextRegisterInfo.h) | 11 |
6 files changed, 9 insertions, 10 deletions
diff --git a/lldb/source/Host/CMakeLists.txt b/lldb/source/Host/CMakeLists.txt index a64a0274738..f41804c7254 100644 --- a/lldb/source/Host/CMakeLists.txt +++ b/lldb/source/Host/CMakeLists.txt @@ -22,7 +22,6 @@ add_host_subdirectory(common common/NativeWatchpointList.cpp common/NativeProcessProtocol.cpp common/NativeRegisterContext.cpp - common/NativeRegisterContextRegisterInfo.cpp common/NativeThreadProtocol.cpp common/OptionParser.cpp common/PipeBase.cpp diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h index a16c65b64a0..4dfc5365f35 100644 --- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h +++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h @@ -10,10 +10,10 @@ #ifndef lldb_NativeRegisterContextLinux_h #define lldb_NativeRegisterContextLinux_h -#include "lldb/Host/common/NativeRegisterContextRegisterInfo.h" #include "lldb/Host/common/NativeThreadProtocol.h" #include "Plugins/Process/Linux/NativeProcessLinux.h" +#include "Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h" namespace lldb_private { namespace process_linux { diff --git a/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h b/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h index f539dfa76f6..1de59db4dd9 100644 --- a/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h +++ b/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h @@ -10,10 +10,10 @@ #ifndef lldb_NativeRegisterContextNetBSD_h #define lldb_NativeRegisterContextNetBSD_h -#include "lldb/Host/common/NativeRegisterContextRegisterInfo.h" #include "lldb/Host/common/NativeThreadProtocol.h" #include "Plugins/Process/NetBSD/NativeProcessNetBSD.h" +#include "Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h" namespace lldb_private { namespace process_netbsd { diff --git a/lldb/source/Plugins/Process/Utility/CMakeLists.txt b/lldb/source/Plugins/Process/Utility/CMakeLists.txt index 71c2cab4716..87f4cc669ca 100644 --- a/lldb/source/Plugins/Process/Utility/CMakeLists.txt +++ b/lldb/source/Plugins/Process/Utility/CMakeLists.txt @@ -9,6 +9,7 @@ add_lldb_library(lldbPluginProcessUtility PLUGIN InferiorCallPOSIX.cpp LinuxSignals.cpp MipsLinuxSignals.cpp + NativeRegisterContextRegisterInfo.cpp NetBSDSignals.cpp RegisterContextDarwin_arm.cpp RegisterContextDarwin_arm64.cpp diff --git a/lldb/source/Host/common/NativeRegisterContextRegisterInfo.cpp b/lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.cpp index 5ff596b5769..0b181436242 100644 --- a/lldb/source/Host/common/NativeRegisterContextRegisterInfo.cpp +++ b/lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.cpp @@ -7,7 +7,7 @@ // //===----------------------------------------------------------------------===// -#include "lldb/Host/common/NativeRegisterContextRegisterInfo.h" +#include "NativeRegisterContextRegisterInfo.h" #include "lldb/lldb-private-forward.h" #include "lldb/lldb-types.h" diff --git a/lldb/include/lldb/Host/common/NativeRegisterContextRegisterInfo.h b/lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h index 908989a0624..c1b597462b6 100644 --- a/lldb/include/lldb/Host/common/NativeRegisterContextRegisterInfo.h +++ b/lldb/source/Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h @@ -1,5 +1,4 @@ -//===-- NativeRegisterContextRegisterInfo.h ----------------------*- C++ -//-*-===// +//===-- NativeRegisterContextRegisterInfo.h ---------------------*- C++ -*-===// // // The LLVM Compiler Infrastructure // @@ -8,13 +7,13 @@ // //===----------------------------------------------------------------------===// -#ifndef lldb_NativeRegisterContextRegisterInfo_h -#define lldb_NativeRegisterContextRegisterInfo_h +#ifndef LLDB_PLUGINS_PROCESS_UTIILTY_NATIVE_REGISTER_CONTEXT_REGISTER_INFO +#define LLDB_PLUGINS_PROCESS_UTIILTY_NATIVE_REGISTER_CONTEXT_REGISTER_INFO #include <memory> -#include "NativeRegisterContext.h" -#include "Plugins/Process/Utility/RegisterInfoInterface.h" +#include "RegisterInfoInterface.h" +#include "lldb/Host/common/NativeRegisterContext.h" namespace lldb_private { class NativeRegisterContextRegisterInfo : public NativeRegisterContext { |

