[lldb] Test 'frame select -r' and fix that INT32_MIN breaks the option parser

llvm-svn: 370734

4 files changed, 72 insertions, 16 deletions

diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/select/Makefile b/lldb/packages/Python/lldbsuite/test/commands/frame/select/Makefile
new file mode 100644
index 00000000000..99bfa7e03b4
--- /dev/null
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/select/Makefile
@@ -0,0 +1,3 @@
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp
+include $(LEVEL)/Makefile.rules
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py b/lldb/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py
new file mode 100644
index 00000000000..ae7cb21af21
--- /dev/null
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py
@@ -0,0 +1,37 @@
+"""
+Test 'frame select' command.
+"""
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+class TestFrameSelect(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    @no_debug_info_test
+    def test_relative(self):
+        self.build()
+
+        lldbutil.run_to_source_breakpoint(self,
+            "// Set break point at this line.", lldb.SBFileSpec("main.cpp"))
+
+        self.expect("frame select -r 1", substrs=["nested2() at"])
+        self.expect("frame select -r -1", substrs=["nested3() at"])
+
+        self.expect("frame select -r -1", error=True, substrs=["Already at the bottom of the stack."])
+        self.expect("frame select -r -2147483647", error=True, substrs=["Already at the bottom of the stack."])
+        self.expect("frame select -r -2147483648", error=True, substrs=["error: invalid frame offset argument '-2147483648'"])
+        self.expect("frame select -r -2147483649", error=True, substrs=["error: invalid frame offset argument '-2147483649'"])
+
+        self.expect("frame select -r 1", substrs=["nested2() at"])
+        self.expect("frame select -r -2", substrs=["nested3() at"])
+        self.expect("frame select -r 1", substrs=["nested2() at"])
+        self.expect("frame select -r -2147483647", substrs=["nested3() at"])
+        self.expect("frame select -r 1", substrs=["nested2() at"])
+        self.expect("frame select -r -2147483648", error=True, substrs=["error: invalid frame offset argument '-2147483648'"])
+        self.expect("frame select -r -2147483649", error=True, substrs=["error: invalid frame offset argument '-2147483649'"])
+
+        self.expect("frame select -r 100")
+        self.expect("frame select -r 1", error=True, substrs=["Already at the top of the stack."])
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/select/main.cpp b/lldb/packages/Python/lldbsuite/test/commands/frame/select/main.cpp
new file mode 100644
index 00000000000..c852bdb7e64
--- /dev/null
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/select/main.cpp
@@ -0,0 +1,16 @@
+int nested3() {
+  return 3; // Set break point at this line.
+}
+
+int nested2() {
+  return 2 + nested3();
+}
+
+int nested1() {
+  return 1 + nested2();
+}
+
+
+int main(int argc, char **argv) {
+  return nested1();
+}
diff --git a/lldb/source/Commands/CommandObjectFrame.cpp b/lldb/source/Commands/CommandObjectFrame.cpp
index e519780872f..5cf2d6cd587 100644
--- a/lldb/source/Commands/CommandObjectFrame.cpp
+++ b/lldb/source/Commands/CommandObjectFrame.cpp
@@ -246,13 +246,15 @@ public:
       Status error;
       const int short_option = m_getopt_table[option_idx].val;
       switch (short_option) {
-      case 'r':
-        if (option_arg.getAsInteger(0, relative_frame_offset)) {
-          relative_frame_offset = INT32_MIN;
+        case 'r': {
+        int32_t offset = 0;
+        if (option_arg.getAsInteger(0, offset) || offset == INT32_MIN) {
           error.SetErrorStringWithFormat("invalid frame offset argument '%s'",
                                          option_arg.str().c_str());
-        }
+        } else
+          relative_frame_offset = offset;
         break;
+      }
 
       default:
         llvm_unreachable("Unimplemented option");
@@ -261,15 +263,13 @@ public:
       return error;
     }
 
-    void OptionParsingStarting(ExecutionContext *execution_context) override {
-      relative_frame_offset = INT32_MIN;
-    }
-
+    void OptionParsingStarting(ExecutionContext *execution_context) override {}
+    
     llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
       return llvm::makeArrayRef(g_frame_select_options);
     }
 
-    int32_t relative_frame_offset;
+    llvm::Optional<int32_t> relative_frame_offset;
   };
 
   CommandObjectFrameSelect(CommandInterpreter &interpreter)
@@ -307,15 +307,15 @@ protected:
     Thread *thread = m_exe_ctx.GetThreadPtr();
 
     uint32_t frame_idx = UINT32_MAX;
-    if (m_options.relative_frame_offset != INT32_MIN) {
+    if (m_options.relative_frame_offset.hasValue()) {
       // The one and only argument is a signed relative frame index
       frame_idx = thread->GetSelectedFrameIndex();
       if (frame_idx == UINT32_MAX)
         frame_idx = 0;
 
-      if (m_options.relative_frame_offset < 0) {
-        if (static_cast<int32_t>(frame_idx) >= -m_options.relative_frame_offset)
-          frame_idx += m_options.relative_frame_offset;
+      if (*m_options.relative_frame_offset < 0) {
+        if (static_cast<int32_t>(frame_idx) >= -*m_options.relative_frame_offset)
+          frame_idx += *m_options.relative_frame_offset;
         else {
           if (frame_idx == 0) {
             // If you are already at the bottom of the stack, then just warn
@@ -326,15 +326,15 @@ protected:
           } else
             frame_idx = 0;
         }
-      } else if (m_options.relative_frame_offset > 0) {
+      } else if (*m_options.relative_frame_offset > 0) {
         // I don't want "up 20" where "20" takes you past the top of the stack
         // to produce
         // an error, but rather to just go to the top.  So I have to count the
         // stack here...
         const uint32_t num_frames = thread->GetStackFrameCount();
         if (static_cast<int32_t>(num_frames - frame_idx) >
-            m_options.relative_frame_offset)
-          frame_idx += m_options.relative_frame_offset;
+            *m_options.relative_frame_offset)
+          frame_idx += *m_options.relative_frame_offset;
         else {
           if (frame_idx == num_frames - 1) {
             // If we are already at the top of the stack, just warn and don't