diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2011-03-03 07:24:36 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2011-03-03 07:24:36 +0000 |
| commit | d92d17bf679ff9f95278446da27b0c166edf59ac (patch) | |
| tree | d6c72ec23f87c708c7c7189f3c3c00e63eed30d8 | |
| parent | 6f6d739b6ee627cc194930f528ddd1d62dde6450 (diff) | |
| download | bcm5719-llvm-d92d17bf679ff9f95278446da27b0c166edf59ac.tar.gz bcm5719-llvm-d92d17bf679ff9f95278446da27b0c166edf59ac.zip | |
PR9352: Always emit a relocation for weak symbols. Not emitting relocations
for calls to weak symbols with a definition has the appearance of working
with LLVM-generated code because weak symbol definitions are put in their
own sections.
llvm-svn: 126933
| -rw-r--r-- | llvm/lib/MC/ELFObjectWriter.cpp | 19 | ||||
| -rw-r--r-- | llvm/test/MC/ELF/weak-relocation.s | 15 |
2 files changed, 34 insertions, 0 deletions
diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp index 77017fb4d93..7488b1b6c2a 100644 --- a/llvm/lib/MC/ELFObjectWriter.cpp +++ b/llvm/lib/MC/ELFObjectWriter.cpp @@ -317,6 +317,13 @@ namespace { MCDataFragment *F, const MCSectionData *SD); + virtual bool + IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm, + const MCSymbolData &DataA, + const MCFragment &FB, + bool InSet, + bool IsPCRel) const; + virtual void WriteObject(MCAssembler &Asm, const MCAsmLayout &Layout); virtual void WriteSection(MCAssembler &Asm, const SectionIndexMapTy &SectionIndexMap, @@ -1438,6 +1445,18 @@ void ELFObjectWriter::WriteObject(MCAssembler &Asm, } } +bool +ELFObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm, + const MCSymbolData &DataA, + const MCFragment &FB, + bool InSet, + bool IsPCRel) const { + if (DataA.getFlags() & ELF_STB_Weak) + return false; + return MCObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl( + Asm, DataA, FB,InSet, IsPCRel); +} + MCObjectWriter *llvm::createELFObjectWriter(MCELFObjectTargetWriter *MOTW, raw_ostream &OS, bool IsLittleEndian) { diff --git a/llvm/test/MC/ELF/weak-relocation.s b/llvm/test/MC/ELF/weak-relocation.s new file mode 100644 index 00000000000..ef331d7e6da --- /dev/null +++ b/llvm/test/MC/ELF/weak-relocation.s @@ -0,0 +1,15 @@ +// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump | FileCheck %s + +// Test that weak symbols always produce relocations + + .weak foo +foo: +bar: + call foo + +//CHECK: # Relocation 0x00000000 +//CHECK-NEXT: (('r_offset', 0x00000001) +//CHECK-NEXT: ('r_sym', 0x00000005) +//CHECK-NEXT: ('r_type', 0x00000002) +//CHECK-NEXT: ('r_addend', 0xfffffffc) +//CHECK-NEXT: ), |
