Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-04-16T18:12:13+00:00 2020-04-16T18:12:13+00:00 Jonas Paulsson paulsson@linux.vnet.ibm.com 2020-03-04T16:11:40+00:00 urn:sha1:5fbba36cbe93f12da5c4d6063db21cf35ecc9bfc SimplifyCFG should not merge empty return blocks and leave a CallBr behind with a duplicated destination since the verifier will then trigger an assert. This patch checks for this case and avoids the transformation. CodeGenPrepare has a similar check which also has a FIXME comment about why this is needed. It seems perhaps better if these two passes would eventually instead update the CallBr instruction instead of just checking and avoiding. This fixes https://bugs.llvm.org/show_bug.cgi?id=45062. Review: Craig Topper Differential Revision: https://reviews.llvm.org/D75620 (cherry picked from commit c2dafe12dc24f7f1326f5c4c6a3b23f1485f1bd6) 2019-12-25T00:27:51+00:00 Fangrui Song maskray@google.com 2019-12-25T00:11:33+00:00 urn:sha1:a36ddf0aa9db5c1086e04f56b5f077b761712eb5 2019-12-25T00:05:15+00:00 Fangrui Song maskray@google.com 2019-12-25T00:02:47+00:00 urn:sha1:eb16435b5e5df68d2410bbe4c08ef8ce8aa8b2f4 2019-12-24T23:57:33+00:00 Fangrui Song maskray@google.com 2019-12-24T23:52:21+00:00 urn:sha1:502a77f125f43ffde57af34d3fd1b900248a91cd 2019-12-16T10:41:21+00:00 Bjorn Pettersson bjorn.a.pettersson@ericsson.com 2019-12-13T14:53:40+00:00 urn:sha1:e5f07080b8ac73dd573e81a186925a122ab8a39d Summary: In commit d60f34c20a2f31335c8d5626e (llvm-svn 317128, PR35113) MergeBlockIntoPredecessor was changed into discarding some dbg.value intrinsics referring to PHI values, post-splice due to loop rotation. That elimination of dbg.value intrinsics did not consider which dbg.value to keep depending on the context (e.g. if the variable is changing its value several times inside the basic block). In the past that hasn't been such a big problem since CodeGenPrepare::placeDbgValues has moved the dbg.value to be next to the PHI node anyway. But after commit 00e238896cd8ad3a7d7 CodeGenPrepare isn't doing that any longer, so we need to be more careful when avoiding duplicate dbg.value intrinsics in MergeBlockIntoPredecessor. This patch replaces the code that tried to avoid duplicate dbg.values by using the RemoveRedundantDbgInstrs helper. Reviewers: aprantl, jmorse, vsk Reviewed By: aprantl, vsk Subscribers: jholewinski, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D71480 2019-12-13T14:30:21+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-13T09:55:45+00:00 urn:sha1:97572775d2fe088d8059b3a9423f6d8539fafe33 GEP index size can be specified in the DataLayout, introduced in D42123. However, there were still places in which getIndexSizeInBits was used interchangeably with getPointerSizeInBits. This notably caused issues with Instcombine's visitPtrToInt; but the unit tests was incorrect, so this remained undiscovered. This fixes the buildbot failures. Differential Revision: https://reviews.llvm.org/D68328 Patch by Joseph Faulls! 2019-12-12T10:29:54+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-12T10:25:14+00:00 urn:sha1:f798eb21eca97dc44ed40da52ece22780fb74230 This reverts commit 5f6208778ff92567c57d7c1e2e740c284d7e69a5. This caused failures in Transforms/PhaseOrdering/scev-custom-dl.ll const: Assertion `getBitWidth() == CR.getBitWidth() && "ConstantRange types don't agree!"' failed. 2019-12-12T10:07:01+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-02T11:13:43+00:00 urn:sha1:5f6208778ff92567c57d7c1e2e740c284d7e69a5 GEP index size can be specified in the DataLayout, introduced in D42123. However, there were still places in which getIndexSizeInBits was used interchangeably with getPointerSizeInBits. This notably caused issues with Instcombine's visitPtrToInt; but the unit tests was incorrect, so this remained undiscovered. Differential Revision: https://reviews.llvm.org/D68328 Patch by Joseph Faulls! 2019-12-11T00:03:17+00:00 Vlad Tsyrklevich vtsyrklevich@google.com 2019-12-10T23:50:10+00:00 urn:sha1:636c93ed11a5f98b5c3ff88241460d61cb7785bb This reverts commit f2ba93971ccc236c0eef5323704d31f48107e04f, it was causing build timeouts on sanitizer-x86_64-linux-autoconf such as http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/44917 2019-12-10T13:33:32+00:00 stozer stephen.tozer@sony.com 2019-12-05T10:01:47+00:00 urn:sha1:f2ba93971ccc236c0eef5323704d31f48107e04f basic blocks Originally applied in 72ce759928e6dfee6a9efa310b966c19722352ba. Fixed a build failure caused by incorrect use of cast instead of dyn_cast. This reverts commit 8b0780f795eb58fca0a2456e308adaaa1a0b5013.