Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-03-19T09:12:16+00:00 2020-03-19T09:12:16+00:00 Hans Wennborg hans@chromium.org 2020-03-19T09:12:16+00:00 urn:sha1:5401d393f88b9fa99a8d3a2a1b3013e757d958a2 2020-03-19T09:02:25+00:00 Sanjay Patel spatel@rotateright.com 2020-02-10T22:13:26+00:00 urn:sha1:623461b2ce421cd287f1bea50c0998003375a782 As discussed in PR41083: https://bugs.llvm.org/show_bug.cgi?id=41083 ...we can assert/crash in EarlyCSE using the current hashing scheme and instructions with flags. ValueTracking's matchSelectPattern() may rely on overflow (nsw, etc) or other flags when detecting patterns such as min/max/abs composed of compare+select. But the value numbering / hashing mechanism used by EarlyCSE intersects those flags to allow more CSE. Several alternatives to solve this are discussed in the bug report. This patch avoids the issue by doing simple matching of min/max/abs patterns that never requires instruction flags. We give up some CSE power because of that, but that is not expected to result in much actual performance difference because InstCombine will canonicalize these patterns when possible. It even has this comment for abs/nabs: /// Canonicalize all these variants to 1 pattern. /// This makes CSE more likely. (And this patch adds PhaseOrdering tests to verify that the expected transforms are still happening in the standard optimization pipelines. I left this code to use ValueTracking's "flavor" enum values, so we don't have to change the callers' code. If we decide to go back to using the ValueTracking call (by changing the hashing algorithm instead), it should be obvious how to replace this chunk. Differential Revision: https://reviews.llvm.org/D74285 (cherry picked from commit b8ebc11f032032c7ca449f020a1fe40346e707c8) 2020-03-19T09:02:25+00:00 Sanjay Patel spatel@rotateright.com 2020-02-10T20:10:47+00:00 urn:sha1:cfa792458fc47f9890d94a2718288c269c8a2a6e Test that instcombine and early-cse can cooperate to reduce sequences of select patterns that are not composed of the same underlying instructions. There's a bug in EarlyCSE (PR41083), and we can test how much a possible fix (D74285) may affect optimization. (cherry picked from commit 0ad6e726ec7eee8ef14a89fa288d5a1420d96b1e) 2019-12-13T14:30:21+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-13T09:55:45+00:00 urn:sha1:97572775d2fe088d8059b3a9423f6d8539fafe33 GEP index size can be specified in the DataLayout, introduced in D42123. However, there were still places in which getIndexSizeInBits was used interchangeably with getPointerSizeInBits. This notably caused issues with Instcombine's visitPtrToInt; but the unit tests was incorrect, so this remained undiscovered. This fixes the buildbot failures. Differential Revision: https://reviews.llvm.org/D68328 Patch by Joseph Faulls! 2019-12-12T10:29:54+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-12T10:25:14+00:00 urn:sha1:f798eb21eca97dc44ed40da52ece22780fb74230 This reverts commit 5f6208778ff92567c57d7c1e2e740c284d7e69a5. This caused failures in Transforms/PhaseOrdering/scev-custom-dl.ll const: Assertion `getBitWidth() == CR.getBitWidth() && "ConstantRange types don't agree!"' failed. 2019-12-12T10:07:01+00:00 Nicola Zaghen nicola.zaghen@imgtec.com 2019-12-02T11:13:43+00:00 urn:sha1:5f6208778ff92567c57d7c1e2e740c284d7e69a5 GEP index size can be specified in the DataLayout, introduced in D42123. However, there were still places in which getIndexSizeInBits was used interchangeably with getPointerSizeInBits. This notably caused issues with Instcombine's visitPtrToInt; but the unit tests was incorrect, so this remained undiscovered. Differential Revision: https://reviews.llvm.org/D68328 Patch by Joseph Faulls! 2019-11-27T21:45:47+00:00 Dávid Bolvanský david.bolvansky@gmail.com 2019-11-27T21:44:43+00:00 urn:sha1:40963b2bf0e72626d21917a08f3c86e56541ae7a This reverts commit 7ca7d62c6ea1680ec0a1861083669596547fdd6f. Commited accidentally. 2019-11-27T21:36:51+00:00 Dávid Bolvanský david.bolvansky@gmail.com 2019-11-26T19:50:56+00:00 urn:sha1:7ca7d62c6ea1680ec0a1861083669596547fdd6f Summary: PR44149 Reviewers: jdoerfert Subscribers: mehdi_amini, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70737 2019-11-27T04:28:52+00:00 Eric Christopher echristo@gmail.com 2019-11-27T04:28:52+00:00 urn:sha1:fd39b1bb20cec32c310ae9b6f1b4603c17a5f832 This reapplies: 8ff85ed905a7306977d07a5cd67ab4d5a56fafb4 Original commit message: As a follow-up to my initial mail to llvm-dev here's a first pass at the O1 described there. This change doesn't include any change to move from selection dag to fast isel and that will come with other numbers that should help inform that decision. There also haven't been any real debuggability studies with this pipeline yet, this is just the initial start done so that people could see it and we could start tweaking after. Test updates: Outside of the newpm tests most of the updates are coming from either optimization passes not run anymore (and without a compelling argument at the moment) that were largely used for canonicalization in clang. Original post: http://lists.llvm.org/pipermail/llvm-dev/2019-April/131494.html Tags: #llvm Differential Revision: https://reviews.llvm.org/D65410 This reverts commit c9ddb02659e3ece7a0d9d6b4dac7ceea4ae46e6d. 2019-11-26T04:32:13+00:00 Muhammad Omair Javaid omair.javaid@linaro.org 2019-11-26T04:32:13+00:00 urn:sha1:c9ddb02659e3ece7a0d9d6b4dac7ceea4ae46e6d This reverts commit 8ff85ed905a7306977d07a5cd67ab4d5a56fafb4. This commit introduced 9 new failures on lldb buildbot host at http://lab.llvm.org:8014/builders/lldb-aarch64-ubuntu Following tests were failing: lldb-api :: functionalities/tail_call_frames/ambiguous_tail_call_seq1/TestAmbiguousTailCallSeq1.py lldb-api :: functionalities/tail_call_frames/ambiguous_tail_call_seq2/TestAmbiguousTailCallSeq2.py lldb-api :: functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py lldb-api :: functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py lldb-api :: functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py lldb-api :: functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py lldb-api :: functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py lldb-api :: functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py lldb-api :: functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py lldb-api :: functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py Tags: #llvm Differential Revision: https://reviews.llvm.org/D65410