Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-01-11T10:02:24+00:00 2020-01-11T10:02:24+00:00 Nikita Popov nikita.ppv@gmail.com 2020-01-10T17:20:32+00:00 urn:sha1:ad36d29eaed62e33eabab8ffd2006b9ff5fbd719 For D72519. 2019-06-19T10:50:47+00:00 Orlando Cazalet-Hyams orlando.hyams@sony.com 2019-06-19T10:50:47+00:00 urn:sha1:1251cac62af531401f3012e1975a973ac5c7e3b1 Summary: Bug: https://bugs.llvm.org/show_bug.cgi?id=39024 The bug reports that a vectorized loop is stepped through 4 times and each step through the loop seemed to show a different path. I found two problems here: A) An incorrect line number on a preheader block (for.body.preheader) instruction causes a step into the loop before it begins. B) Instructions in the middle block have different line numbers which give the impression of another iteration. In this patch I give all of the middle block instructions the line number of the scalar loop latch terminator branch. This seems to provide the smoothest debugging experience because the vectorized loops will always end on this line before dropping into the scalar loop. To solve problem A I have altered llvm::SplitBlockPredecessors to accommodate loop header blocks. I have set up a separate review D61933 for a fix which is required for this patch. Reviewers: samsonov, vsk, aprantl, probinson, anemet, hfinkel, jmorse Reviewed By: hfinkel, jmorse Subscribers: jmorse, javed.absar, eraman, kcc, bjope, jmellorcrummey, hfinkel, gbedwell, hiraditya, zzheng, llvm-commits Tags: #llvm, #debug-info Differential Revision: https://reviews.llvm.org/D60831 > llvm-svn: 363046 llvm-svn: 363786 2019-06-12T08:34:51+00:00 Orlando Cazalet-Hyams orlando.hyams@sony.com 2019-06-12T08:34:51+00:00 urn:sha1:a94715639619a258a714deeb485d2d7fb9dd1cb9 This reverts commit 1a0f7a2077b70c9864faa476e15b048686cf1ca7. See phabricator thread for D60831. llvm-svn: 363132 2019-06-11T10:37:20+00:00 Orlando Cazalet-Hyams orlando.hyams@sony.com 2019-06-11T10:37:20+00:00 urn:sha1:1a0f7a2077b70c9864faa476e15b048686cf1ca7 Summary: Bug: https://bugs.llvm.org/show_bug.cgi?id=39024 The bug reports that a vectorized loop is stepped through 4 times and each step through the loop seemed to show a different path. I found two problems here: A) An incorrect line number on a preheader block (for.body.preheader) instruction causes a step into the loop before it begins. B) Instructions in the middle block have different line numbers which give the impression of another iteration. In this patch I give all of the middle block instructions the line number of the scalar loop latch terminator branch. This seems to provide the smoothest debugging experience because the vectorized loops will always end on this line before dropping into the scalar loop. To solve problem A I have altered llvm::SplitBlockPredecessors to accommodate loop header blocks. I have set up a separate review D61933 for a fix which is required for this patch. Reviewers: samsonov, vsk, aprantl, probinson, anemet, hfinkel, jmorse Reviewed By: hfinkel, jmorse Subscribers: jmorse, javed.absar, eraman, kcc, bjope, jmellorcrummey, hfinkel, gbedwell, hiraditya, zzheng, llvm-commits Tags: #llvm, #debug-info Differential Revision: https://reviews.llvm.org/D60831 llvm-svn: 363046 2019-05-07T22:35:56+00:00 Reid Kleckner rnk@google.com 2019-05-07T22:35:56+00:00 urn:sha1:a9cc7d71acc637940fd1d621d0fea8dcd1d17229 llvm-svn: 360203 2019-05-07T20:57:11+00:00 Kostya Serebryany kcc@google.com 2019-05-07T20:57:11+00:00 urn:sha1:b9c57683026e51f5b0a1f779c95895b16e8de04c llvm-svn: 360190 2019-05-07T15:37:38+00:00 Orlando Cazalet-Hyams orlando.hyams@sony.com 2019-05-07T15:37:38+00:00 urn:sha1:78a6062c24dc51180101666b82afa8d7fab920d1 Summary: Bug: https://bugs.llvm.org/show_bug.cgi?id=39024 The bug reports that a vectorized loop is stepped through 4 times and each step through the loop seemed to show a different path. I found two problems here: A) An incorrect line number on a preheader block (for.body.preheader) instruction causes a step into the loop before it begins. B) Instructions in the middle block have different line numbers which give the impression of another iteration. In this patch I give all of the middle block instructions the line number of the scalar loop latch terminator branch. This seems to provide the smoothest debugging experience because the vectorized loops will always end on this line before dropping into the scalar loop. To solve problem A I have altered llvm::SplitBlockPredecessors to accommodate loop header blocks. Reviewers: samsonov, vsk, aprantl, probinson, anemet, hfinkel Reviewed By: hfinkel Subscribers: bjope, jmellorcrummey, hfinkel, gbedwell, hiraditya, zzheng, llvm-commits Tags: #llvm, #debug-info Differential Revision: https://reviews.llvm.org/D60831 llvm-svn: 360162 2019-04-17T04:52:47+00:00 Eric Christopher echristo@gmail.com 2019-04-17T04:52:47+00:00 urn:sha1:cee313d288a4faf0355d76fb6e0e927e211d08a5 The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552 2019-04-17T02:12:23+00:00 Eric Christopher echristo@gmail.com 2019-04-17T02:12:23+00:00 urn:sha1:a86343512845c9c1fdbac865fea88aa5fce7142a As it's causing some bot failures (and per request from kbarton). This reverts commit r358543/ab70da07286e618016e78247e4a24fcb84077fda. llvm-svn: 358546 2018-11-14T01:47:32+00:00 Reid Kleckner rnk@google.com 2018-11-14T01:47:32+00:00 urn:sha1:41390b47de8b8e9952cf466d8220c17ec1bbc326 It broke the Windows self-host: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/1457 llvm-svn: 346823