Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-09-20T23:41:29+00:00 2019-09-20T23:41:29+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-09-20T23:41:29+00:00 urn:sha1:e021d6909436c6baac2dc7c9065340862a9b9aa2 dotest -f does not work on Python3. The name types.UnboundMethodType was an alias for types.MethodType in 2.7, but it does not exist in python3. MethodType works in both. Also the actual type returned from SomeClass.some_method in python3 will be types.Function, not MethodType. Patch by: Lawrence D'Anna Differential revision: https://reviews.llvm.org/D67791 llvm-svn: 372441 2019-08-13T22:18:01+00:00 Aaron Smith aaron.smith@microsoft.com 2019-08-13T22:18:01+00:00 urn:sha1:5146a9ea5d8d3c91cee5d2d2ad4c50491e7a4c58 Summary: Thanks to Hui Huang and the reviewers for all the help with this patch. Reviewers: labath, Hui, jfb, clayborg, amccarth Reviewed By: labath Subscribers: amccarth, compnerd, dexonsmith, mgorny, jfb, teemperor, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D63165 llvm-svn: 368759 2018-12-20T20:44:23+00:00 Jonas Devlieghere jonas@devlieghere.com 2018-12-20T20:44:23+00:00 urn:sha1:dcc8fc9e985f16a6df878ec0ff7212e0a2da0c8f Unexpected successes should be considered failures because they can hide regressions when not addressed. When a test is fixed and not re-enabled, it can easily regress without us noticing. I couldn't find a good way to make this change other than changing it in the unittest2 framework. I know this is less than optimal but since we have the dependency checked in and the change is pretty fundamental to the framework I think it's not unreasonable. Differential revision: https://reviews.llvm.org/D55835 llvm-svn: 349818 2016-09-06T20:57:50+00:00 Kate Stone katherine.stone@apple.com 2016-09-06T20:57:50+00:00 urn:sha1:b9c1b51e45b845debb76d8658edabca70ca56079 *** to conform to clang-format’s LLVM style. This kind of mass change has *** two obvious implications: Firstly, merging this particular commit into a downstream fork may be a huge effort. Alternatively, it may be worth merging all changes up to this commit, performing the same reformatting operation locally, and then discarding the merge for this particular commit. The commands used to accomplish this reformatting were as follows (with current working directory as the root of the repository): find . \( -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname "*.mm" \) -exec clang-format -i {} + find . -iname "*.py" -exec autopep8 --in-place --aggressive --aggressive {} + ; The version of clang-format used was 3.9.0, and autopep8 was 1.2.4. Secondly, “blame” style tools will generally point to this commit instead of a meaningful prior commit. There are alternatives available that will attempt to look through this change and find the appropriate prior commit. YMMV. llvm-svn: 280751 2015-11-06T21:37:07+00:00 Zachary Turner zturner@google.com 2015-11-06T21:37:07+00:00 urn:sha1:059e52c44ceda28ca21a0299bb171cad2da0bc4c Explanation from a Python wizard (not me) about why this exhibited different behavior under Python 2 and Python 3. `cmp` is a builtin_function_or_method in Python 2.7, which doesn't have a __get__ and doesn't qualify as a "descriptor". Your lambda is a regular function which qualifies as a descriptor whose __get__ method returns a bound instance. His suggested fix was to write sortTestMethodsUsing = staticmethod(cmp_) However, I don't think `sortTestMethodsUsing` (or any of the other fields of `TestLoader`) should be class attributes anyway. They are all accessed through self, so they should be instance attributes. So the fix employed here is to convert them to instance attributes. Differential Revision: http://reviews.llvm.org/D14453 Reviewed By: Todd Fiala llvm-svn: 252346 2015-11-05T19:21:56+00:00 Zachary Turner zturner@google.com 2015-11-05T19:21:56+00:00 urn:sha1:71d468be66cbdff20426508a2c117c0af833d54a llvm-svn: 252189 2015-11-05T18:38:02+00:00 Zachary Turner zturner@google.com 2015-11-05T18:38:02+00:00 urn:sha1:cc8aa4f619072c3a1392ffc5eba8ebf0b56b6ae7 llvm-svn: 252181 2015-11-03T21:37:42+00:00 Zachary Turner zturner@google.com 2015-11-03T21:37:42+00:00 urn:sha1:46f1784bac7f8388c4a8185801c815d24dd0210f This patch actually introduces a dependency from unittest2 to six. This should be ok since both packages are in our own repo, and we assume a sys.path of the top-level script that can find the third party packages. So unittest2 should be able to find six. llvm-svn: 251983 2015-11-03T21:02:00+00:00 Zachary Turner zturner@google.com 2015-11-03T21:02:00+00:00 urn:sha1:234860133b202479d03e34d67eeb7b0e9df92250 unittest2 was using print statements in a few places, and also using the `cmp` function (which is removed in Python 3). Again, we need to stop using unittest2 and using unittest instead, but this seems like an easier route for now. llvm-svn: 251978 2015-11-03T21:01:45+00:00 Zachary Turner zturner@google.com 2015-11-03T21:01:45+00:00 urn:sha1:9618980a19d4234d93dd69f92f6b875e72b89a1b Old-style: `raise foo, bar` New-style: `raise foo(bar)` These two statements are equivalent, but the former is an error in Python 3. llvm-svn: 251977