bcm5719-llvm/lldb/test/Shell/ObjectFile/PECOFF, branch meklort-10.0.1

[LLDB] [test] Add a missing "REQUIRES: arm" line

2019-11-28T11:18:15+00:00

[LLDB] Always interpret arm instructions as thumb on windows

2019-11-28T09:27:00+00:00

Windows on ARM always uses thumb mode, and doesn't have most of the mechanisms that are used in e.g. ELF for distinguishing between arm and thumb. Differential Revision: https://reviews.llvm.org/D70796

[LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

2019-11-28T09:27:00+00:00

COFF section names can either be stored truncated to 8 chars, in the section header, or as a longer section name, stored separately in the string table. libunwind locates the .eh_frame section by runtime introspection, which only works for section names stored in the section header (as the string table isn't mapped at runtime). To support this behaviour, lld always truncates the section names for sections that will be mapped, like .eh_frame. Differential Revision: https://reviews.llvm.org/D70745

[LLDB] [PECOFF] Fix error handling for executables that object::createBinary errors out on

2019-10-31T09:26:21+00:00

llvm::object::createBinary returns an Expected<>, which requires not only checking the object for success, but also requires consuming the Error, if one was set. Use LLDB_LOG_ERROR for this case, and change an existing similar log statement to use it as well, to make sure the Error is consumed even if the log channel is disabled. Differential Revision: https://reviews.llvm.org/D69646

COFF: Set section permissions

2019-10-30T13:13:21+00:00

Summary: This enables us to reason about whether a given address can be executable, for instance during unwinding. Reviewers: amccarth, mstorsjo Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D69102

[LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections

2019-10-29T12:48:35+00:00

The virtual container/header section caused the section list to be offset by one, but by using FindSectionByID, the layout of the section list shouldn't matter. Differential Revision: https://reviews.llvm.org/D69366

lldb/COFF: Create a separate "section" for the file header

2019-10-25T22:11:53+00:00

In an attempt to ensure that every part of the module's memory image is accounted for, D56537 created a special "container section" spanning the entire image. While that seemed reasonable at the time (and it still mostly does), it did create a problem of what to put as the "file size" of the section, because the image is not continuous on disk, as we generally assume (which is why I put zero there). Additionally, this arrangement makes it unclear what kind of permissions should be assigned to that section (which is what my next patch does). To get around these, this patch partially reverts D56537, and goes back to top-level sections. Instead, what I do is create a new "section" for the object file header, which is also being loaded into memory, though its not considered to be a section in the strictest sense. This makes it possible to correctly assign file size section, and we can later assign permissions to it as well. Reviewers: amccarth, mstorsjo Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D69100

[LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

2019-10-15T08:32:46+00:00

This matches all other architectures listed in the same file. This fixes debugging aarch64 executables with lldb-server, which otherwise fails, with log messages like these: Target::SetArchitecture changing architecture to aarch64 (aarch64-pc-windows-msvc) Target::SetArchitecture Trying to select executable file architecture aarch64 (aarch64-pc-windows-msvc) ArchSpec::SetArchitecture sets the vendor to llvm::Triple::PC for any coff/win32 combination, and if this doesn't match the triple set by the PECOFF module, things doesn't seem to work with when using lldb-server. Differential Revision: https://reviews.llvm.org/D68939 llvm-svn: 374867

Re-land "[test] Split LLDB tests into API, Shell & Unit"

2019-10-09T19:22:02+00:00

The original patch got reverted because it broke `check-lldb` on a clean build. This fixes that. llvm-svn: 374201

Revert [test] Split LLDB tests into API, Shell & Unit

2019-10-09T17:35:43+00:00

as it appears to have broken check-lldb. This reverts r374184 (git commit 22314179f0660c172514b397060fd8f34b586e82) llvm-svn: 374187