Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-01-14T17:14:28+00:00 2020-01-14T17:14:28+00:00 Jonas Devlieghere jonas@devlieghere.com 2020-01-14T17:13:15+00:00 urn:sha1:fd19ffc6a502f8e647696d550abb04a6c8c1b182 llvm_unreachable is marked noreturn so the compiler can assume the code for printing the error message in release builds isn't hit which defeats the purpose. 2020-01-14T02:25:23+00:00 Jonas Devlieghere jonas@devlieghere.com 2020-01-14T02:23:39+00:00 urn:sha1:d1e3b23be46ac3ada8f5fe844629ad5bc233c24d This fixes an error thrown by clang 3.8 that no viable conversion from returned value to the function return type. 2020-01-07T12:03:56+00:00 Raphael Isemann teemperor@gmail.com 2020-01-07T11:13:03+00:00 urn:sha1:65fdb34219f33b2871a532a38814ac4ebea10abc Summary: There are a few places in LLDB where we do a `reinterpret_cast` for conversions that we could also do with `static_cast`. This patch moves all this code to `static_cast`. Reviewers: shafik, JDevlieghere, labath Reviewed By: labath Subscribers: arphaman, usaxena95, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D72161 2020-01-03T22:23:42+00:00 Jonas Devlieghere jonas@devlieghere.com 2020-01-03T22:17:25+00:00 urn:sha1:d2b19d455de22fe3c8aa192320e1ff9a4eb1a365 It's not up to YAML to validate the semantics of the GDB remote packet struct. This is especially wrong here as there's nothing that says that the amount of bytes transmitted matches the packet payload size. 2019-12-17T08:13:48+00:00 Raphael Isemann teemperor@gmail.com 2019-12-17T08:13:23+00:00 urn:sha1:ba6f25d7d3671f8ff1d072a43a292950dbbf899e 2019-12-13T11:33:47+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:21:59+00:00 urn:sha1:3ca771ba594fbd40da7ef842c04b5842e7b2a83c 2019-12-10T23:04:45+00:00 Eric Christopher echristo@gmail.com 2019-12-10T23:04:02+00:00 urn:sha1:1d41d1bcdfd70cf8f77bb32e2617392395c299a4 On multiple retry this issue won't duplicate - will revisit with author if duplication works again. This reverts commit c9e0b354e2749ce7ab553974692cb35c8651a869. 2019-12-10T20:29:46+00:00 Eric Christopher echristo@gmail.com 2019-12-10T20:19:30+00:00 urn:sha1:c9e0b354e2749ce7ab553974692cb35c8651a869 This was causing a crash in opt+assert builds on linux and a follow-up message was posted. This reverts commit e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf 2019-12-10T19:16:52+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-12-07T23:28:30+00:00 urn:sha1:e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf When running the test suite with always capture on, a handful of tests are failing because they have multiple targets and therefore multiple GDB remote connections. The current reproducer infrastructure is capable of dealing with that. This patch reworks the GDB remote provider to support multiple GDB remote connections, similar to how the reproducers support shadowing multiple command interpreter inputs. The provider now keeps a list of packet recorders which deal with a single GDB remote connection. During replay we rely on the order of creation to match the number of packets to the GDB remote connection. Differential revision: https://reviews.llvm.org/D71105 2019-12-06T10:16:39+00:00 Raphael Isemann teemperor@gmail.com 2019-12-06T10:04:33+00:00 urn:sha1:fc39b94849c89843aebb210c5d9be9c48e2b43a6 These functions are an implementation detail of RegisterValue, so it doesn't make a lot of sense to implement them in a totally unrelated class.