Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-12-06T17:18:57+00:00 2019-12-06T17:18:57+00:00 Muhammad Omair Javaid omair.javaid@linaro.org 2019-12-06T17:12:39+00:00 urn:sha1:b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 Summary: This patch simplifies register accesses in NativeRegisterContextLinux_arm64 and also adds some bare minimum caching to avoid multiple calls to ptrace during a stop. Linux ptrace returns data in the form of structures containing GPR/FPR data. This means that one single call is enough to read all GPRs or FPRs. We do that once per stop and keep reading from or writing to the buffer that we have in NativeRegisterContextLinux_arm64 class. Before a resume or detach we write all buffers back. This is tested on aarch64 thunder x1 with Ubuntu 18.04. Also tested regressions on x86_64. Reviewers: labath, clayborg Reviewed By: labath Subscribers: kristof.beyls, lldb-commits Differential Revision: https://reviews.llvm.org/D69371 2019-10-31T09:58:17+00:00 Guilherme Andrade guiandrade@google.com 2019-10-31T09:46:58+00:00 urn:sha1:e46c6644db8432584e82ef7ddfc9d0f36543f205 Summary: This change increases the offset of MPX registers (by 128) so they do not overlap with the offset associated with AVX registers. That was causing MPX data in GDBRemoteRegisterContext::m_reg_data to get overwritten. Reviewers: labath Reviewed By: labath Subscribers: JDevlieghere, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68874 2019-09-02T12:50:18+00:00 Pavel Labath pavel@labath.sk 2019-09-02T12:50:18+00:00 urn:sha1:3f3673ead99c2ad917a31a04af9f99a889bf016a Summary: This patch follows the spirit of D63594, and removes some null checks for things which should be operating invariants. Specifically {Read,Write}[GF]PR now no longer check whether the supplied buffers are null, because they never are. After this, the Do*** versions of these function no longer serve any purpose and are inlined into their callers. Other cleanups are possible here too, but I am taking this one step at a time because this involves a lot of architecture-specific code, which I don't have the hardware to test on (I did do a build-test though). Reviewers: mgorny, jankratochvil, omjavaid, alexandreyy, uweigand Subscribers: nemanjai, javed.absar, kbarton, lldb-commits Differential Revision: https://reviews.llvm.org/D66744 llvm-svn: 370653 2019-08-14T22:19:23+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-08-14T22:19:23+00:00 urn:sha1:a8f3ae7c9cefa8296d119f92ca444087cdccf712 Now that we've moved to C++14, we no longer need the llvm::make_unique implementation from STLExtras.h. This patch is a mechanical replacement of (hopefully) all the llvm::make_unique instances across the monorepo. Differential revision: https://reviews.llvm.org/D66259 llvm-svn: 368933 2019-07-25T06:38:33+00:00 Pavel Labath pavel@labath.sk 2019-07-25T06:38:33+00:00 urn:sha1:ee74c9e5fdd8c8bcd08d219ed6132713323113a6 Summary: Due to a logic error, lldb-server ended up asserting/crashing every time the debugged process attempted an execve(). This fixes the error, and extends TestExec to work on other platforms too. The "extension" consists of avoiding non-standard posix_spawn extensions and using the classic execve() call, which should be available on any platform that actually supports re-execing. I change the test decorator from @skipUnlessDarwin to @skipIfWindows. Reviewers: clayborg, jasonmolenda Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D65207 llvm-svn: 366985 2019-07-24T17:56:10+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-07-24T17:56:10+00:00 urn:sha1:63e5fb76ecfed3434252868d8cf07d676f979f2f This patch replaces explicit calls to log::Printf with the new LLDB_LOGF macro. The macro is similar to LLDB_LOG but supports printf-style format strings, instead of formatv-style format strings. So instead of writing: if (log) log->Printf("%s\n", str); You'd write: LLDB_LOG(log, "%s\n", str); This change was done mechanically with the command below. I replaced the spurious if-checks with vim, since I know how to do multi-line replacements with it. find . -type f -name '*.cpp' -exec \ sed -i '' -E 's/log->Printf\(/LLDB_LOGF\(log, /g' "{}" + Differential revision: https://reviews.llvm.org/D65128 llvm-svn: 366936 2019-07-23T20:40:37+00:00 Antonio Afonso antonio.afonso@gmail.com 2019-07-23T20:40:37+00:00 urn:sha1:70795c1e3a7fd1172ba31954da02b75db71af388 This reverts commit 9c10b620c0619611dfe062216459431955ac4801. llvm-svn: 366848 2019-07-23T20:40:30+00:00 Antonio Afonso antonio.afonso@gmail.com 2019-07-23T20:40:30+00:00 urn:sha1:05e32bad137c80a7ff28f8f002ff0e9f614ad2af This reverts commit 08c38f77c5fb4d3735ec215032fed8ee6730b3db. llvm-svn: 366847 2019-07-01T13:18:19+00:00 Pavel Labath pavel@labath.sk 2019-07-01T13:18:19+00:00 urn:sha1:c12dfcf1f56ba06589f63f49d256efeb38b3e8d5 A bunch of places were checking that DataBufferHeap::GetBytes returns a non-null pointer right after constructing it. The only time when GetBytes returns a null pointer is if it is empty (and I'm not sure that even this is a good idea), but that is clearly not the case here, as the buffer was constructed with a non-zero size just a couple of lines back. llvm-svn: 364754 2019-07-01T12:41:20+00:00 Pavel Labath pavel@labath.sk 2019-07-01T12:41:20+00:00 urn:sha1:08c38f77c5fb4d3735ec215032fed8ee6730b3db D62502, together with D62503 have broken the builds which have XML support enabled. Reverting D62503 (r364355) fixed that, but has broken has left some of the tests introduced by D62502 broken more or less nondeternimistically (it depended on whether the system happens to place the library list near unreadable pages of memory). I attempted to make a partial fix for this in r364748, but Jan Kratochvil pointed out that this reintroduces the problem which reverting D62503 was trying to solve. So instead, I back out the whole thing so we can get back to a clean slate that works for everyone. We can figure out a way forward from there. This reverts r364748, r363772 and r363707. llvm-svn: 364751