Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-07-12T20:08:41+00:00 2019-07-12T20:08:41+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-07-12T20:08:41+00:00 urn:sha1:69de1bbe322e3136e36999febac00638f93860f8 Differential revision: https://reviews.llvm.org/D64661 llvm-svn: 365950 2019-05-23T11:14:47+00:00 Konrad Kleine kkleine@redhat.com 2019-05-23T11:14:47+00:00 urn:sha1:248a13057a4adbdb8d511b1458daf39d01a4b520 Summary: NFC = [[ https://llvm.org/docs/Lexicon.html#nfc | Non functional change ]] This commit is the result of modernizing the LLDB codebase by using `nullptr` instread of `0` or `NULL`. See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html for more information. This is the command I ran and I to fix and format the code base: ``` run-clang-tidy.py \ -header-filter='.*' \ -checks='-*,modernize-use-nullptr' \ -fix ~/dev/llvm-project/lldb/.* \ -format \ -style LLVM \ -p ~/llvm-builds/debug-ninja-gcc ``` NOTE: There were also changes to `llvm/utils/unittest` but I did not include them because I felt that maybe this library shall be updated in isolation somehow. NOTE: I know this is a rather large commit but it is a nobrainer in most parts. Reviewers: martong, espindola, shafik, #lldb, JDevlieghere Reviewed By: JDevlieghere Subscribers: arsenm, jvesely, nhaehnle, hiraditya, JDevlieghere, teemperor, rnkovacs, emaste, kubamracek, nemanjai, ki.stfu, javed.absar, arichardson, kbarton, jrtc27, MaskRay, atanasyan, dexonsmith, arphaman, jfb, jsji, jdoerfert, lldb-commits, llvm-commits Tags: #lldb, #llvm Differential Revision: https://reviews.llvm.org/D61847 llvm-svn: 361484 2019-04-10T20:48:55+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-04-10T20:48:55+00:00 urn:sha1:8b3af63b8993e45b1783853a3fcf6f36bfbed81b A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135 2019-03-06T21:22:25+00:00 Adrian Prantl aprantl@apple.com 2019-03-06T21:22:25+00:00 urn:sha1:0e4c482124f098957fc13bcfbabc36775dd190ab My apologies for the large patch. With the exception of ConstString.h itself it was entirely produced by sed. ConstString has exactly one const char * data member, so passing a ConstString by reference is not any more efficient than copying it by value. In both cases a single pointer is passed. But passing it by value makes it harder to accidentally return the address of a local object. (This fixes rdar://problem/48640859 for the Apple folks) Differential Revision: https://reviews.llvm.org/D59030 llvm-svn: 355553 2019-02-13T06:25:41+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-02-13T06:25:41+00:00 urn:sha1:d5b440369dbb0d41e6ecd47d6ac7410201e27f17 The `ap` suffix is a remnant of lldb's former use of auto pointers, before they got deprecated. Although all their uses were replaced by unique pointers, some variables still carried the suffix. In r353795 I removed another auto_ptr remnant, namely redundant calls to ::get for unique_pointers. Jim justly noted that this is a good opportunity to clean up the variable names as well. I went over all the changes to ensure my find-and-replace didn't have any undesired side-effects. I hope I didn't miss any, but if you end up at this commit doing a git blame on a weirdly named variable, please know that the change was unintentional. llvm-svn: 353912 2019-02-12T03:47:39+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-02-12T03:47:39+00:00 urn:sha1:70355ace3f075553043f6715390891633afc604e This commit removes redundant calls to smart pointer’s ::get() method. https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-smartptr-get.html llvm-svn: 353795 2019-01-19T08:50:56+00:00 Chandler Carruth chandlerc@gmail.com 2019-01-19T08:50:56+00:00 urn:sha1:2946cd701067404b99c39fb29dc9c74bd7193eb3 to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636 2018-12-15T00:15:33+00:00 Jonas Devlieghere jonas@devlieghere.com 2018-12-15T00:15:33+00:00 urn:sha1:a6682a413d893bc1ed6190dfadcee806155da66e This patch simplifies boolean expressions acorss LLDB. It was generated using clang-tidy with the following command: run-clang-tidy.py -checks='-*,readability-simplify-boolean-expr' -format -fix $PWD Differential revision: https://reviews.llvm.org/D55584 llvm-svn: 349215 2018-11-12T21:24:50+00:00 Jonas Devlieghere jonas@devlieghere.com 2018-11-12T21:24:50+00:00 urn:sha1:87e403aa4f62d7385999041abce5fdadb8741a47 This fixes some UB in isLocal detected by the sanitized bot. llvm-svn: 346707 2018-11-12T19:08:19+00:00 Davide Italiano davide@freebsd.org 2018-11-12T19:08:19+00:00 urn:sha1:9a89d93d62525518faa518766b6fae4d14b26140 It broke the lldb sanitizer bots. llvm-svn: 346694