bcm5719-llvm/lldb/source/Host/windows, branch meklort-10.0.1

[Host] Return status directly from RunShellCommand

2019-10-04T19:54:45+00:00

Thanks for catching this, Pavel! llvm-svn: 373783

[Host] Don't discard return value from RunShellCommand

2019-10-04T19:37:46+00:00

The recent change to expand arguments with the user's shell sometimes caused a timeout and the error was not propagated. llvm-svn: 373776

Convert FileSystem::Open() to return Expected

2019-09-26T17:54:59+00:00

Summary: This patch converts FileSystem::Open from this prototype: Status Open(File &File, const FileSpec &file_spec, ...); to this one: llvm::Expected> Open(const FileSpec &file_spec, ...); This is beneficial on its own, as llvm::Expected is a more modern and recommended error type than Status. It is also a necessary step towards https://reviews.llvm.org/D67891, and further developments for lldb_private::File. Reviewers: JDevlieghere, jasonmolenda, labath Reviewed By: labath Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D67996 llvm-svn: 373003

Revert r372788 "Host: use the platform identifiers from LLVM (NFC)"

2019-09-25T11:55:16+00:00

> Use symbolic constants for the platform identifiers rather than replicating them > locally. This broke the build of LLDB on Windows, see http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9182 which fails with e.g. E:\build_slave\lldb-x64-windows-ninja\llvm\include\llvm/BinaryFormat/COFF.h(96): error C2059: syntax error: 'constant' E:\build_slave\lldb-x64-windows-ninja\llvm\include\llvm/BinaryFormat/COFF.h(96): error C3805: 'constant': unexpected token, expected either '}' or a ',' E:\build_slave\lldb-x64-windows-ninja\llvm\include\llvm/BinaryFormat/COFF.h(128): error C2059: syntax error: 'constant' ... llvm-svn: 372847

Host: use the platform identifiers from LLVM (NFC)

2019-09-24T22:55:44+00:00

Use symbolic constants for the platform identifiers rather than replicating them locally. llvm-svn: 372788

[LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures

2019-09-23T20:43:22+00:00

Differential Revision: https://reviews.llvm.org/D67913 llvm-svn: 372658

[LLDB] Remove a now redundant windows specific workaround

2019-09-23T12:03:33+00:00

vsnprintf(NULL, 0, ...) works for measuring the needed string size on all supported Windows variants; it's supported since at least MSVC 2015 (and LLVM requires a newer version than that), and works on both msvcrt.dll (since at least XP) and UCRT with MinGW. The previous use of ifdefs was wrong as well, as __MINGW64__ only is defined for 64 bit targets, and the define without trailing underscores is never defined automatically (neither by clang nor by gcc). Differential Revision: https://reviews.llvm.org/D67861 llvm-svn: 372591

[LLDB] Add a void* cast when passing object pointers to printf %p

2019-09-23T12:03:28+00:00

This fixes build warnings in MinGW mode. Also remove leftover if (log) {} around the log macro. Differential Revision: https://reviews.llvm.org/D67896 llvm-svn: 372590

Fix error in ProcessLauncherWindows.cpp

2019-09-13T18:50:39+00:00

Restored missing parens on a function call. llvm-svn: 371882

Enable lldb-server on Windows

2019-08-13T23:50:54+00:00

Summary: This commit contains three small changes to enable lldb-server on Windows. - Add lldb-server for Windows to the build - Disable pty redirection on Windows for the initial lldb-server bring up - Add a support to get the parent pid for a process on Windows - Ifdef some signals which aren't supported on Windows Thanks to Hui Huang for the help with this patch! Reviewers: labath Reviewed By: labath Subscribers: JDevlieghere, compnerd, Hui, amccarth, xiaobai, srhines, mgorny, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D61686 llvm-svn: 368774