Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-10-14T18:53:27+00:00 2019-10-14T18:53:27+00:00 Lawrence D'Anna lawrence_danna@apple.com 2019-10-14T18:53:27+00:00 urn:sha1:d5768e3d0e887ba75222c6ceda9c6fa2c93e00c1 Summary: The build directory name is based on the test method name, so having two test methods with the same name in the same test file is a problem, even if they're in different test classes. On linux and darwin this conflict can go unnoticed, but windows has different filesystem semantics and it will fail when one process tries to delete files still held open by another. The problem is fixed just by changing the name of one of the test methods. Reviewers: JDevlieghere, jasonmolenda, labath, stella.stamenova Reviewed By: stella.stamenova Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68951 llvm-svn: 374803 2019-10-10T19:24:07+00:00 Lawrence D'Anna lawrence_danna@apple.com 2019-10-10T19:24:07+00:00 urn:sha1:ab1cd65f19144f75e7a4e4ad2f1c85e5fa3ceb7d Summary: If you look at what this test is doing, it's actually quite mysterious why it works at all. It sets the input file inside a "with open". As soon as the with block ends, that file will be closed. And yet somehow LLDB reads commands from it anyway. What's actually happening is that the file descriptor gets dup'd when something inside LLDB calls File::GetStream(). I think it's fair to say that what this test is doing is illegal and it has no right to expect it to work. This patch updates the test with two cases. One uses the SBFile api, and actually transfers ownership of the original file descriptor to the debugger. The other just uses the old FILE* API, but in a sane way. I also set NO_DEBUG_INFO_TESTCASE, because this test doesn't use any debug info and doesn't need to run three times. Reviewers: JDevlieghere, jasonmolenda, labath Reviewed By: labath Subscribers: aprantl, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68738 llvm-svn: 374424 2019-09-04T07:46:25+00:00 Pavel Labath pavel@labath.sk 2019-09-04T07:46:25+00:00 urn:sha1:418a272f4ab4221c37a9272d48fd31d5ac1bddc1 Summary: Instead of each test case knowing its depth relative to the test root, we can just have dotest add the folder containing Makefile.rules to the include path. This was motivated by r370616, though I have been wanting to do this ever since we moved to building tests out-of-tree. The only manually modified files in this patch are lldbinline.py and plugins/builder_base.py. The rest of the patch has been produced by this shell command: find . \( -name Makefile -o -name '*.mk' \) -exec sed --in-place -e '/LEVEL *:\?=/d' -e '1,2{/^$/d}' -e 's,\$(LEVEL)/,,' {} + Reviewers: teemperor, aprantl, espindola, jfb Subscribers: emaste, javed.absar, arichardson, christof, arphaman, lldb-commits Differential Revision: https://reviews.llvm.org/D67083 llvm-svn: 370845 2019-08-14T08:11:20+00:00 Pavel Labath pavel@labath.sk 2019-08-14T08:11:20+00:00 urn:sha1:72ef113d40ef57d9dd4cf7ba6819e2048df99fc6 Summary: It seems this was an unintended side-effect of D26698. AFAICT, these functions did return an empty string before that patch, and the patch contained code which attempted to ensure that, but those efforts were negated by ConstString::AsCString, which by default returns a nullptr even for empty strings. This patch: - fixes the GetOutput/Error methods to really return empty strings - adds and explicit test for that - removes a workaround in lldbtest.py, which was masking this problem from our other tests Reviewers: jingham, clayborg Subscribers: zturner, lldb-commits Differential Revision: https://reviews.llvm.org/D65739 llvm-svn: 368806 2019-08-02T08:06:22+00:00 Raphael Isemann teemperor@gmail.com 2019-08-02T08:06:22+00:00 urn:sha1:9eedbc4f266d1e49d335d48c4c0f717401d927d2 llvm-svn: 367663 2019-05-15T00:08:55+00:00 Jim Ingham jingham@apple.com 2019-05-15T00:08:55+00:00 urn:sha1:7d7b788fb1866f31a1e3b5b787b1476920320548 Authored by: Lukas Boger Differential Revision: https://reviews.llvm.org/D61602 llvm-svn: 360730 2018-01-19T23:24:35+00:00 Adrian Prantl aprantl@apple.com 2018-01-19T23:24:35+00:00 urn:sha1:595048f3ecf3317aa2d32bed5141a526415f5aea in TestBase::getBuildArtifact(). This NFC commit is in preparation for https://reviews.llvm.org/D42281 (compile the LLDB tests out-of-tree). Differential Revision: https://reviews.llvm.org/D42280 llvm-svn: 323007 2016-09-06T20:57:50+00:00 Kate Stone katherine.stone@apple.com 2016-09-06T20:57:50+00:00 urn:sha1:b9c1b51e45b845debb76d8658edabca70ca56079 *** to conform to clang-format’s LLVM style. This kind of mass change has *** two obvious implications: Firstly, merging this particular commit into a downstream fork may be a huge effort. Alternatively, it may be worth merging all changes up to this commit, performing the same reformatting operation locally, and then discarding the merge for this particular commit. The commands used to accomplish this reformatting were as follows (with current working directory as the root of the repository): find . \( -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname "*.mm" \) -exec clang-format -i {} + find . -iname "*.py" -exec autopep8 --in-place --aggressive --aggressive {} + ; The version of clang-format used was 3.9.0, and autopep8 was 1.2.4. Secondly, “blame” style tools will generally point to this commit instead of a meaningful prior commit. There are alternatives available that will attempt to look through this change and find the appropriate prior commit. YMMV. llvm-svn: 280751 2016-02-04T23:04:17+00:00 Zachary Turner zturner@google.com 2016-02-04T23:04:17+00:00 urn:sha1:9a1a2946affdfcefd7cd2e407f4dbf51082d597e llvm-svn: 259838 2015-11-03T19:20:39+00:00 Zachary Turner zturner@google.com 2015-11-03T19:20:39+00:00 urn:sha1:19474e1801ca3eafe9a07d0cf49ee20a9104b434 This module was originally intended to be imported by top-level scripts to be able to find the LLDB packages and third party libraries. Packages themselves shouldn't need to import it, because by the time it gets into the package, the top-level script should have already done this. Indeed, it was just adding the same values to sys.path multiple times, so this patch is essentially no functional change. To make sure it doesn't get re-introduced, we also delete the `use_lldb_suite` module from `lldbsuite/test`, although the original copy still remains in `lldb/test` llvm-svn: 251963