Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-12-13T11:34:49+00:00 2019-12-13T11:34:49+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:24:23+00:00 urn:sha1:9bace26a690a778ec0f09a9aae9537dfbdb6f42f Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454 2019-12-13T11:23:04+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:11:23+00:00 urn:sha1:a52a11139c0e3db9b00079aa1516080742b79475 Summary: A lot of tests do this trick but the vast majority of them don't even call `print()`. Most of this patch was generated by a script that just looks at all the files and deletes the line if there is no `print (` or `print(` anywhere else in the file. I checked the remaining tests manually and deleted the import if we never call print (but instead do stuff like `expr print(...)` and similar false-positives). I also corrected the additional empty lines after the import in the files that I manually edited. Reviewers: JDevlieghere, labath, jfb Reviewed By: labath Subscribers: dexonsmith, wuzish, nemanjai, kbarton, christof, arphaman, abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71452 2019-09-25T00:36:00+00:00 Adrian Prantl aprantl@apple.com 2019-09-25T00:36:00+00:00 urn:sha1:5c4c9e61725526e1e7afca87b395a0efd2aeabfd This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS. Differential Revision: https://reviews.llvm.org/D67984 llvm-svn: 372795 2019-09-04T07:46:25+00:00 Pavel Labath pavel@labath.sk 2019-09-04T07:46:25+00:00 urn:sha1:418a272f4ab4221c37a9272d48fd31d5ac1bddc1 Summary: Instead of each test case knowing its depth relative to the test root, we can just have dotest add the folder containing Makefile.rules to the include path. This was motivated by r370616, though I have been wanting to do this ever since we moved to building tests out-of-tree. The only manually modified files in this patch are lldbinline.py and plugins/builder_base.py. The rest of the patch has been produced by this shell command: find . \( -name Makefile -o -name '*.mk' \) -exec sed --in-place -e '/LEVEL *:\?=/d' -e '1,2{/^$/d}' -e 's,\$(LEVEL)/,,' {} + Reviewers: teemperor, aprantl, espindola, jfb Subscribers: emaste, javed.absar, arichardson, christof, arphaman, lldb-commits Differential Revision: https://reviews.llvm.org/D67083 llvm-svn: 370845 2019-08-02T08:06:22+00:00 Raphael Isemann teemperor@gmail.com 2019-08-02T08:06:22+00:00 urn:sha1:9eedbc4f266d1e49d335d48c4c0f717401d927d2 llvm-svn: 367663 2019-01-07T16:27:52+00:00 Adrian Prantl aprantl@apple.com 2019-01-07T16:27:52+00:00 urn:sha1:ae9f93b4aa74ca02c11739d280b04ab72555c60e llvm-svn: 350537 2018-01-30T18:29:16+00:00 Adrian Prantl aprantl@apple.com 2018-01-30T18:29:16+00:00 urn:sha1:5ec76fe720e43a9196d3437e1ff448668bf7db6d This patch is the result of a discussion on lldb-dev, see http://lists.llvm.org/pipermail/lldb-dev/2018-January/013111.html for background. For each test (should be eventually: each test configuration) a separate build directory is created and we execute make VPATH=$srcdir/path/to/test -C $builddir/path/to/test -f $srcdir/path/to/test/Makefile -I $srcdir/path/to/test In order to make this work all LLDB tests need to be updated to find the executable in the test build directory, since CWD still points at the test's source directory, which is a requirement for unittest2. Although we have done extensive testing, I'm expecting that this first attempt will break a few bots. Please DO NOT HESITATE TO REVERT this patch in order to get the bots green again. We will likely have to iterate on this some more. Differential Revision: https://reviews.llvm.org/D42281 llvm-svn: 323803 2018-01-25T18:01:27+00:00 Vedant Kumar vsk@apple.com 2018-01-25T18:01:27+00:00 urn:sha1:801362f067ae8875c070cc2bfdbee512cadebab4 Stale global module caches cause problems for the bots. The modules become invalid when clang headers are updated by version control, and tests which use these modules fail to compile, e.g: fatal error: file '.../__stddef_max_align_t.h' has been modified since the module file '/var/.../Darwin.pcm' was built note: please rebuild precompiled header '/var/.../Darwin.pcm' Eventually we should transition to having just a single module cache to speed tests up. This patch should be just enough to fix the spurious bot failures due to stale caches. rdar://36479805, also related to llvm.org/PR36048 Differential Revision: https://reviews.llvm.org/D42277 llvm-svn: 323450 2018-01-19T23:24:35+00:00 Adrian Prantl aprantl@apple.com 2018-01-19T23:24:35+00:00 urn:sha1:595048f3ecf3317aa2d32bed5141a526415f5aea in TestBase::getBuildArtifact(). This NFC commit is in preparation for https://reviews.llvm.org/D42281 (compile the LLDB tests out-of-tree). Differential Revision: https://reviews.llvm.org/D42280 llvm-svn: 323007 2017-12-12T02:52:01+00:00 Davide Italiano davide@freebsd.org 2017-12-12T02:52:01+00:00 urn:sha1:074f858da7440f8ffd438ffe0f26e74ac8e37f9f Remove yet another spurious unexpected success. Ack'ed by Jim Ingham. Fixes PR25743. llvm-svn: 320454