Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-12-13T11:34:49+00:00 2019-12-13T11:34:49+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:24:23+00:00 urn:sha1:9bace26a690a778ec0f09a9aae9537dfbdb6f42f Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454 2019-12-13T11:23:04+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:11:23+00:00 urn:sha1:a52a11139c0e3db9b00079aa1516080742b79475 Summary: A lot of tests do this trick but the vast majority of them don't even call `print()`. Most of this patch was generated by a script that just looks at all the files and deletes the line if there is no `print (` or `print(` anywhere else in the file. I checked the remaining tests manually and deleted the import if we never call print (but instead do stuff like `expr print(...)` and similar false-positives). I also corrected the additional empty lines after the import in the files that I manually edited. Reviewers: JDevlieghere, labath, jfb Reviewed By: labath Subscribers: dexonsmith, wuzish, nemanjai, kbarton, christof, arphaman, abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71452 2019-12-11T17:17:03+00:00 Jason Molenda jmolenda@apple.com 2019-12-11T17:14:52+00:00 urn:sha1:52c5342ebcc173b25c1644335cba7aef8ec73b92 2019-12-09T14:08:59+00:00 Muhammad Omair Javaid omair.javaid@linaro.org 2019-12-09T14:07:14+00:00 urn:sha1:0964733bae2d0823f7b431ee2b16a3fd1dd993e3 This patch removes xfail decorator from some lldb testcases which are passing steadily now for past few week/months on aarch64/linux buildbot. 2019-11-25T19:11:59+00:00 Michał Górny mgorny@gentoo.org 2019-11-08T17:42:37+00:00 urn:sha1:7644d8ba4dc4e06b2db2bfdb7f4d76b9356cb288 Fix handling concurrent watchpoint events so that they are reported correctly in LLDB. If multiple watchpoints are hit concurrently, the NetBSD kernel reports them as series of SIGTRAPs with a thread specified, and the debugger investigates DR6 in order to establish which watchpoint was hit. This is normally fine. However, LLDB disables and reenables the watchpoint on all threads after each hit, which results in the hit status from DR6 being wiped. As a result, it can't establish which watchpoint was hit in successive SIGTRAP processing. In order to workaround this problem, clear DR6 only if the breakpoint is overwritten with a new one. More specifically, move cleaning DR6 from ClearHardwareWatchpoint() to SetHardwareWatchpointWithIndex(), and do that only if the newly requested watchpoint is different from the one being set previously. This ensures that the disable-enable logic of LLDB does not clear watchpoint hit status for the remaining threads. This also involves refactoring of watchpoint logic. With the old logic, clearing watchpoint involved wiping dr6 & dr7, and setting it setting dr{0..3} & dr7. With the new logic, only enable bit is cleared from dr7, and the remaining bits are cleared/overwritten while setting new watchpoint. Differential Revision: https://reviews.llvm.org/D70025 2019-11-25T19:11:59+00:00 Michał Górny mgorny@gentoo.org 2019-11-09T10:56:08+00:00 urn:sha1:d970d4d4aa7345ebf8b7169b09f2775a93f86c33 NetBSD ptrace interface does not populate watchpoints to newly-created threads. Solve this via copying the watchpoints from the current thread when new thread is reported via TRAP_LWP. Add a test that verifies that when the user does not have permissions to set watchpoints on NetBSD, the 'watchpoint set' errors out gracefully and thread monitoring does not crash on being unable to copy watchpoints to new threads. Differential Revision: https://reviews.llvm.org/D70023 2019-11-25T19:11:58+00:00 Michał Górny mgorny@gentoo.org 2019-07-12T17:11:31+00:00 urn:sha1:8d9400b65b972cb50fe2266360443192ea107ec9 Implement major improvements to multithreaded program support. Notably, support tracking new and exited threads, associate signals and events with correct threads and support controlling individual threads when resuming. Firstly, use PT_SET_EVENT_MASK to enable reporting of created and exited threads via SIGTRAP. Handle TRAP_LWP events to keep track of the currently running threads. Secondly, update the signal (both generic and SIGTRAP) handling code to account for per-thread signals correctly. Signals delivered to the whole process are reported on all threads, while per-thread signals and events are reported only to the specific thread. The remaining threads are marked as 'stopped with no reason'. Note that NetBSD always stops all threads on debugger events. Thirdly, implement the ability to set every thread as running, stopped or single-stepping separately while continuing the process. This also provides the ability to send a signal to the whole process or to one of its thread while resuming. Differential Revision: https://reviews.llvm.org/D70022 2019-11-16T13:47:20+00:00 Sylvestre Ledru sylvestre@debian.org 2019-11-16T13:46:38+00:00 urn:sha1:9b40a7f3bf7198dd64403cbd83478087e72f994b 2019-10-28T23:15:09+00:00 Jim Ingham jingham@apple.com 2019-10-28T23:15:09+00:00 urn:sha1:651b5e725ee6812fdabb369ed2ecd4740106a82c This test was timing out on the swift CI bots. I didn't see any obvious reason for that, and the test hasn't had problems on greendragon. OTOH, it was a bit oddly written, and needed modernizing, so I did that. Differential Revision: https://reviews.llvm.org/D69453 2019-09-25T00:36:00+00:00 Adrian Prantl aprantl@apple.com 2019-09-25T00:36:00+00:00 urn:sha1:5c4c9e61725526e1e7afca87b395a0efd2aeabfd This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS. Differential Revision: https://reviews.llvm.org/D67984 llvm-svn: 372795