Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-09-01T09:12:37+00:00 2019-09-01T09:12:37+00:00 Raphael Isemann teemperor@gmail.com 2019-09-01T09:12:37+00:00 urn:sha1:29872606d220420d53fde7cc5e3bea15f8da62e7 Summary: As discussed on lldb-dev, this patch moves some LLDB tests into a hierarchy that more closely resembles the commands we use in the LLDB interpreter. This patch should only move tests that use the command interpreter and shouldn't touch any tests that primarily test the SB API. Reviewers: #lldb, jfb, JDevlieghere Reviewed By: #lldb, JDevlieghere Subscribers: dexonsmith, arphaman, JDevlieghere, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D67033 llvm-svn: 370605 2019-08-02T08:06:22+00:00 Raphael Isemann teemperor@gmail.com 2019-08-02T08:06:22+00:00 urn:sha1:9eedbc4f266d1e49d335d48c4c0f717401d927d2 llvm-svn: 367663 2019-03-09T12:47:38+00:00 Michal Gorny mgorny@gentoo.org 2019-03-09T12:47:38+00:00 urn:sha1:377d9dc8728af681c3a302fa0a0a64fc0810f62f Adjust the XFAIL-ing tests to match consistent results from buildbot. I'm going to work on differences between them and my local results following this. llvm-svn: 355774 2019-03-04T16:54:06+00:00 Michal Gorny mgorny@gentoo.org 2019-03-04T16:54:06+00:00 urn:sha1:de11105d2ece076e9d8dcfb01286643e81af8922 Add a convenience 'expectedFailureNetBSD' decorator and mark all tests currently failing on NetBSD with it. Also skip a few tests that hang the test suite. This should establish a baseline for the test suite and get us closer to enabling tests on buildbot. This will help us catch regressions while we still have a lot of work to do to get tests working. It seems that there are also some flaky tests. I am going to address them later on. Differential Revision: https://reviews.llvm.org/D58527 llvm-svn: 355320 2018-06-13T19:02:44+00:00 Stella Stamenova stilis@microsoft.com 2018-06-13T19:02:44+00:00 urn:sha1:9d6fabf9e37b1c2a69ba5d15b1dcbcb044990dc6 Summary: test_set_working_dir was testing two scenario: failure to set the working dir because of a non existent directory and succeeding to set the working directory. Since the negative case fails on both Linux and Windows, the positive case was never tested. I split the test into two which allows us to always run both the negative and positive cases. The positive case now succeeds on Linux and the negative case still fails. During the investigation, it turned out that lldbtest.py will try to execute a process launch command up to 3 times if the command failed. This means that we could be covering up intermittent failures by running any test that does process launch multiple times without ever realizing it. I've changed the counter to 1 (though it can still be overwritten with the environment variable). This change also fixes both the positive and negative cases on Windows. There were a few issues: 1) In ProcessLauncherWindows::LaunchProcess, the error was not retrieved until CloseHandle was possibly called. Since CloseHandle is also a system API, its success would overwrite any existing error that could be retrieved using GetLastError. So by the time the error was retrieved, it was now a success. 2) In DebuggerThread::StopDebugging TerminateProcess was called on the process handle regardless of whether it was a valid handle. This was causing the process to crash when the handle was LLDB_INVALID_PROCESS (0xFFFFFFFF). 3) In ProcessWindows::DoLaunch we need to check that the working directory exists before launching the process to have the same behavior as other platforms which first check the directory and then launch process. This way we also control the exact error string. Reviewers: labath, zturner, asmith, jingham Reviewed By: labath Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D48050 llvm-svn: 334642 2018-03-15T15:21:54+00:00 Pavel Labath labath@google.com 2018-03-15T15:21:54+00:00 urn:sha1:0428ddd7fc85aa356ea8ae01836ebd46ffafe1dd This test started failing after r327625. The cause seems difference in the treatment of relative --stdin paths between MacOS (debugserver?) and linux (lldb-server?). Linux treats this as relative to the debuggers PWD, while MacOS as relative to (I think) the future PWD of the launched process. This fixes the issue by using absolute paths, which should work everywhere, but we should probably unify this path handling as well. I'll ask around about what is the expected behavior here. llvm-svn: 327633 2018-03-15T13:47:09+00:00 Pavel Labath labath@google.com 2018-03-15T13:47:09+00:00 urn:sha1:107052ff9ded599519445833d755628703027801 Summary: The changes here fall into several categories. - some tests were redirecting inferior stdout/err to a file. For these I make sure we use an absolute path for the file. I also create a lldbutil.read_file_on_target helper function to encapsulate the differences between reading a file locally and remotely. - some tests were redirecting the pexpect I/O into a file. For these I use a python StringIO object to avoid creating a file altogether. - the TestSettings inferior was creating a file. Here, I make sure the inferior is launched with pwd=build-dir so that the files end up created there. - lldb-mi --log (used by some tests) creates a log file in PWD without the ability say differently. To make this work I make sure to run lldb-mi with PWD=build_dir. This in turn necessitated a couple of changes in other lldb-mi tests, which were using relative paths to access the source tree. Reviewers: aprantl Subscribers: ki.stfu, mehdi_amini, lldb-commits Differential Revision: https://reviews.llvm.org/D44159 llvm-svn: 327625 2018-01-31T21:39:00+00:00 Adrian Prantl aprantl@apple.com 2018-01-31T21:39:00+00:00 urn:sha1:7faa9dac84b80a9160512e4e1a14f2cfca66d38a llvm-svn: 323917 2018-01-30T18:29:16+00:00 Adrian Prantl aprantl@apple.com 2018-01-30T18:29:16+00:00 urn:sha1:5ec76fe720e43a9196d3437e1ff448668bf7db6d This patch is the result of a discussion on lldb-dev, see http://lists.llvm.org/pipermail/lldb-dev/2018-January/013111.html for background. For each test (should be eventually: each test configuration) a separate build directory is created and we execute make VPATH=$srcdir/path/to/test -C $builddir/path/to/test -f $srcdir/path/to/test/Makefile -I $srcdir/path/to/test In order to make this work all LLDB tests need to be updated to find the executable in the test build directory, since CWD still points at the test's source directory, which is a requirement for unittest2. Although we have done extensive testing, I'm expecting that this first attempt will break a few bots. Please DO NOT HESITATE TO REVERT this patch in order to get the bots green again. We will likely have to iterate on this some more. Differential Revision: https://reviews.llvm.org/D42281 llvm-svn: 323803 2018-01-19T23:24:35+00:00 Adrian Prantl aprantl@apple.com 2018-01-19T23:24:35+00:00 urn:sha1:595048f3ecf3317aa2d32bed5141a526415f5aea in TestBase::getBuildArtifact(). This NFC commit is in preparation for https://reviews.llvm.org/D42281 (compile the LLDB tests out-of-tree). Differential Revision: https://reviews.llvm.org/D42280 llvm-svn: 323007