Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-01-01T22:22:49+00:00 2020-01-01T22:22:49+00:00 Saleem Abdulrasool compnerd@compnerd.org 2020-01-01T22:19:41+00:00 urn:sha1:fb170fd652bf2fcc4c2cd54aaf384591d8df266b Now that we are building the python bindings on Windows once more, the extended testsuite is running. Mark a few failing tests and skip a few tests which hang. This should at least bring the bot back to green without reverting the Python changes which are an improvement for the build system and enable another ~35% of the test suite which was previously disabled. 2019-12-13T11:34:49+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:24:23+00:00 urn:sha1:9bace26a690a778ec0f09a9aae9537dfbdb6f42f Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454 2019-12-13T11:23:04+00:00 Raphael Isemann teemperor@gmail.com 2019-12-13T11:11:23+00:00 urn:sha1:a52a11139c0e3db9b00079aa1516080742b79475 Summary: A lot of tests do this trick but the vast majority of them don't even call `print()`. Most of this patch was generated by a script that just looks at all the files and deletes the line if there is no `print (` or `print(` anywhere else in the file. I checked the remaining tests manually and deleted the import if we never call print (but instead do stuff like `expr print(...)` and similar false-positives). I also corrected the additional empty lines after the import in the files that I manually edited. Reviewers: JDevlieghere, labath, jfb Reviewed By: labath Subscribers: dexonsmith, wuzish, nemanjai, kbarton, christof, arphaman, abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71452 2019-12-13T07:30:58+00:00 Muhammad Omair Javaid omair.javaid@linaro.org 2019-12-13T07:03:29+00:00 urn:sha1:5536c62f3c35015802dd59150d422c4ab79db581 This patch removes xpass decorator from tests which were failing due to pr44037. pr44037 was fixed by rev 6ce1a897b6a82e18059fd3b75b8d52ff12c2a605 2019-12-05T01:40:57+00:00 Jim Ingham jingham@apple.com 2019-12-05T01:40:57+00:00 urn:sha1:3151d7af72bee375c06318195870942d4bc12002 options class. This value was hanging around so for instance if you made a scripted breakpoint resolver, then went to set another breakpoint, it would still think you had passed in a class name and the breakpoint wouldn't do what you expected. 2019-12-04T14:57:15+00:00 Joseph Tremoulet jotrem@microsoft.com 2019-11-22T17:59:46+00:00 urn:sha1:95b2e516bd3e4587953e44bf062054ff84f2b057 Summary: Using a BreakpointList corrupts the breakpoints' IDs because BreakpointList::Add sets the ID, so use a vector instead, and update the signature to return the vector wrapped in an llvm::Expected which can propagate any error from the inner call to StringIsBreakpointName. Note that, despite the similar name, SBTarget::FindBreakpointsByName doesn't suffer the same problem, because it uses a SBBreakpointList, which is more like a BreakpointIDList than a BreakpointList under the covers. Add a check to TestBreakpointNames that, without this fix, notices the ID getting mutated and fails. Reviewers: jingham, JDevlieghere Reviewed By: JDevlieghere Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D70907 2019-12-03T09:57:42+00:00 Diana Picus diana.picus@linaro.org 2019-11-19T09:58:52+00:00 urn:sha1:6d18e5366c9a0bffe45b179a830483b3f2ec9fa9 I have either opened new bug reports for these tests, or added links to existing bugs. This should help make the lldb-aarch64-ubuntu buildbot green (there will still be some unexpected passes that someone should look into, but those can be handled later). 2019-11-22T10:20:09+00:00 Martin Svensson poya@me.com 2019-11-22T10:18:47+00:00 urn:sha1:0b0dca9f6fe34333abdb437bd1d3d92c8362a2e6 Summary: Ensure that breakpoint ivar is properly set in exception breakpoint resolver so that exception breakpoints set on dummy targets are resolved once real targets are created and run. Reviewers: jingham Reviewed By: jingham Subscribers: teemperor, JDevlieghere, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D69880 2019-11-19T09:49:00+00:00 Diana Picus diana.picus@linaro.org 2019-11-18T09:39:33+00:00 urn:sha1:bb7c8e984f87e1de7c80abd33d00025ac366efa6 These tests are failing with various assertion failures, but they all throw the following error message first: error: a.out 0x0000002d: adding range [0x14-0x24) which has a base that is less than the function's low PC 0x40060c. See llvm.org/pr44037. Differential Revision: https://reviews.llvm.org/D70381 2019-10-29T22:03:02+00:00 Lawrence D'Anna lawrence_danna@apple.com 2019-10-29T20:42:38+00:00 urn:sha1:a69bbe02a2352271e8b14542073f177e24c499c1 Summary: Move breakpoints from the old, bad ArgInfo::count to the new, better ArgInfo::max_positional_args. Soon ArgInfo::count will be no more. It looks like this functionality is already well tested by `TestBreakpointCommandsFromPython.py`, so there's no need to write additional tests for it. Reviewers: labath, jingham, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D69468