bcm5719-llvm/lldb/packages/Python/lldbsuite/test/api/log, branch meklort-10.0.1 Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2019-09-18T13:41:50+00:00 Fir TestAPILog for gcc 2019-09-18T13:41:50+00:00 Pavel Labath pavel@labath.sk 2019-09-18T13:41:50+00:00 urn:sha1:89ad7f7a1ba245fccf1f64f95a146ada6f6aaac6 different compilers will put different things into __PRETTY_FUNCTION__. For instance gcc will not put a " " in the "const char *" argument, causing our regex matching to fail. This patch relaxes the regexes in this test to account for this difference. llvm-svn: 372224 [test] Fail gracefully if the regex doesn't match 2019-09-16T23:49:42+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-09-16T23:49:42+00:00 urn:sha1:71b32e4175d111e1d2a62bf681b5c49e92ff163a This test is failing on the Fedora bot (staging). Rather than failing with an IndexError, we should trigger an assert and dump the log when the regex doesn't match. llvm-svn: 372052 [test] Update TestAPILog to pass on Windows. 2019-09-13T22:14:59+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-09-13T22:14:59+00:00 urn:sha1:61dc038f8de01ce765387fa06d8cd5d9276cf62f The pretty function macro is including __cdecl on Windows, which was causing the pattern matching to fail. This should fix that. llvm-svn: 371905 [test] Print the log output on failure. 2019-09-13T21:15:03+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-09-13T21:15:03+00:00 urn:sha1:a3e27633a839cf1c45b640f88e00530c59f10e8d This ensures that if the assertion fails we dump the log content. This should help me investigate what the output looks like on Windows, where the test is failing. llvm-svn: 371899 [Reproducer] Include the this pointer in the API log. 2019-09-13T19:08:10+00:00 Jonas Devlieghere jonas@devlieghere.com 2019-09-13T19:08:10+00:00 urn:sha1:449ca01bac853efbf7d4434784af8457f2e0678f The new centralized way of doing API logging through the reproducer macros is lacking a way to easily correlate instances of API objects. Logging the this pointer makes that significantly easier. For methods this is now always passed as the first argument, similar to the self argument in Python. This patch also adds a test case for API logging, which uncovered that we were not quoting strings. Differential revision: https://reviews.llvm.org/D67538 llvm-svn: 371885