bcm5719-llvm/clang/lib/DirectoryWatcher, branch meklort-10.0.1

[Clang] Migrate llvm::make_unique to std::make_unique

2019-08-14T23:04:18+00:00

Now that we've moved to C++14, we no longer need the llvm::make_unique implementation from STLExtras.h. This patch is a mechanical replacement of (hopefully) all the llvm::make_unique instances across the monorepo. Differential revision: https://reviews.llvm.org/D66259 llvm-svn: 368942

[clang][DirectoryWatcher] Fix Windows stub after LLVM change

2019-08-13T22:39:50+00:00

r367979 changed DirectoryWatcher::Create to return an llvm::Expected. Adjust the Windows stub accordingly. (upstreamed from github.com/apple/swift-clang) llvm-svn: 368762

[clang] DirectoryWatcher for Windows stubs (to fix build break).

2019-08-13T22:39:26+00:00

This is just a code skeleton for DirectoryWatcher-windows.cpp so the build on Windows stops breaking. (upstreamed from github.com/apple/swift-clang) llvm-svn: 368761

Remove LLVM mutexes from clang in favor of std::mutex

2019-08-07T14:44:40+00:00

None of those need to be recursive mutexes. No functionality change intended. llvm-svn: 368173

[clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create

2019-08-06T23:25:34+00:00

I also have replaced all the instances of "auto DW = DirectoryWatcher::create" with llvm::Expected> DW = DirectoryWatcher::create to make it more clear that DirectoryWatcher::create is returning an Expected. I've also allowed for logAllUnhandledErrors to consume errors in the case were DirectoryWatcher::create produces them. Differential Revision: https://reviews.llvm.org/D65829 llvm-svn: 368108

[DirectoryWatcher] Fix asserts Mac builds

2019-08-06T07:13:53+00:00

Add a missing semicolon after an assert. Remove the period from the assert message while I'm here, because we don't usually have those. llvm-svn: 367984

[clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

2019-08-06T05:12:23+00:00

Prior to this patch Unix style errno error reporting from the inotify layer was used by DirectoryWatcher::create to simply return a nullptr on error. This would generally be ok, except that in LLVM we have much more robust error reporting through the facilities of llvm::Expected. The other critical thing I stumbled across was that the unit tests for DirectoryWatcher were not failing abruptly when inotify_init() was reporting an error, but would continue with the testing and eventually hit a deadlock in a pathological machine state (ie in the unit test, the return nullptr on ::create was ignored). Generally this pathological state never happens on any build bot, so it is totally understandable that it was overlooked, but on a Linux desktop running a dubious desktop environment (which I will not name) there is a chance that said desktop environment could use up enough inotify instances to exceed the user's limit. These are the conditions that led me to hit the deadlock I am addressing in this patch with more robust error handling. With the new llvm::Expected error handling when your system runs out of inotify instances for your user, the unit test will be forced to handle the error or crash and report the issue to the user instead of weirdly deadlocking on a condition variable wait. Differential Revision: https://reviews.llvm.org/D65704 llvm-svn: 367979

[DirectoryWatcher][linux] Fix build for older kernels

2019-08-05T18:44:07+00:00

Apparently kernel support for IN_EXCL_UNLINK in inotify_add_watch() doesn't imply it's defined in sys/inotify.h. https://bugs.llvm.org/show_bug.cgi?id=42824 llvm-svn: 367906

[DirectoryWatcher] Relax assumption to prevent test flakiness

2019-08-01T23:24:30+00:00

llvm-svn: 367632

Fix Linux build

2019-07-29T23:28:44+00:00

r367274 broke it llvm-svn: 367276