Project Ortega BCM5719 LLVM https://git.raptorcs.com/git/bcm5719-llvm/atom?h=meklort-10.0.1 2020-06-10T11:57:00+00:00 2020-06-10T11:57:00+00:00 Kadir Cetinkaya kadircet@google.com 2020-05-25T15:25:55+00:00 urn:sha1:d623a06a8247b1a04e74ad5f02a30ef351697e00 Summary: Constructors can have implicit initializers, this was crashing define outline. Make sure we find the first "written" ctor initializer to figure out `:` location. Fixes https://github.com/clangd/clangd/issues/400 Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D80521 (cherry picked from commit eeedbd033612e105755156023bdeec2fba4eca21) Fixes https://github.com/clangd/clangd/issues/418 2020-03-04T08:11:44+00:00 Nathan James n.james93@hotmail.co.uk 2020-03-03T09:58:14+00:00 urn:sha1:bca373f73fc82728a8335e7d6cd164e8747139ec Summary: The define out of line refactor tool previously would copy the `virtual`, `override` and `final` specifier into the out of line method definition. This results in malformed code as those specifiers aren't allowed outside the class definition. Reviewers: hokein, kadircet Reviewed By: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang, #clang-tools-extra Differential Revision: https://reviews.llvm.org/D75429 (cherry picked from commit b2666ccca0277371a09e43a0a5a0f78029ba81e5) 2020-01-04T15:28:41+00:00 Kazuaki Ishizaki ishizaki@jp.ibm.com 2020-01-04T15:28:41+00:00 urn:sha1:b7ecf1c1c373c53183ef6ef66efbe4237ff7b96d 2020-01-03T17:18:40+00:00 Sam McCall sam.mccall@gmail.com 2020-01-03T16:26:33+00:00 urn:sha1:f06f439fadf740ea9019f2eb7f26ff88198ed375 Summary: While it's perfectly reasonable for non-named decls such as static_assert to resolve to themselves: - nothing else ever resolves to them - features based on references (hover, highlight, find refs etc) tend to be uninteresting where only trivial references are possible - returning NamedDecl is a more convenient API (we cast to it in many places) - this aligns closer to findExplicitReferences/explicitReferenceTargets This fixes a crash in explicitReferenceTargets: if the target is a non-named decl then there's an invalid unchecked cast to NamedDecl. In practice this means when hovering over e.g. a static_assert: - before ac3f9e4842, we would show a (boring) hover card - after ac3f9e4842, we would crash - after this patch, we will show nothing Reviewers: kadircet, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D72163 2019-12-16T18:07:49+00:00 Sam McCall sam.mccall@gmail.com 2019-12-16T18:07:49+00:00 urn:sha1:6af1ad20d60ef8ea23f2cfdb02d299b3b3114b06 This reverts commit a0ff8cd631add513423fc2d8afa49e9650d01fe3. Buildbot failures I can't chase further tonight. 2019-12-16T14:58:51+00:00 Sam McCall sam.mccall@gmail.com 2019-12-16T14:58:03+00:00 urn:sha1:a0ff8cd631add513423fc2d8afa49e9650d01fe3 This reverts commit 8f876d5105507f874c0fb86bc779c9853eab3fe2. 2019-12-16T14:57:43+00:00 Sam McCall sam.mccall@gmail.com 2019-12-16T14:57:43+00:00 urn:sha1:8f876d5105507f874c0fb86bc779c9853eab3fe2 This reverts commit 2500a8d5d8813a3e31fc9ba8dd45e211439a1e3d. 2019-12-16T14:55:16+00:00 Sam McCall sam.mccall@gmail.com 2019-12-16T14:46:40+00:00 urn:sha1:2500a8d5d8813a3e31fc9ba8dd45e211439a1e3d This reverts commit f0604e73a4daa35a10eb17a998657d6c4bd0e971 The issue with movability of Tweak::Selection was addressed in 7dc388bd9596bbf42633f8a8e450224e39740b60 2019-12-16T14:46:57+00:00 Sam McCall sam.mccall@gmail.com 2019-12-16T14:46:40+00:00 urn:sha1:7dc388bd9596bbf42633f8a8e450224e39740b60 2019-12-16T09:54:40+00:00 Kirill Bobyrev kbobyrev@google.com 2019-12-16T09:33:56+00:00 urn:sha1:3b9715cb219352fb831af144fd68e14e8fd275b4 Reviewed by: Jim Differential Revision: https://reviews.llvm.org/D71455