1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
#include "bmc_update_mock.hpp"
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
#include "util.hpp"
#include "verification_mock.hpp"
#include <memory>
#include <vector>
#include <gtest/gtest.h>
namespace ipmi_flash
{
using ::testing::_;
using ::testing::IsNull;
using ::testing::NotNull;
using ::testing::Return;
using ::testing::StrEq;
using ::testing::StrictMock;
class FirmwareHandlerCommitTest : public ::testing::Test
{
protected:
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs;
std::vector<DataHandlerPack> data;
void SetUp() override
{
blobs = {
{hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
data = {
{FirmwareBlobHandler::UpdateFlags::ipmi, nullptr},
};
}
};
TEST_F(FirmwareHandlerCommitTest, VerifyCannotCommitOnFlashImage)
{
/* Verify the flash image returns failure on this command. It's a fairly
* artificial test.
*/
/* Verify it doesn't get called by using StrictMock. */
std::unique_ptr<VerificationInterface> verifyMock =
std::make_unique<StrictMock<VerificationMock>>();
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
blobs, data, std::move(verifyMock), CreateUpdateMock());
EXPECT_CALL(imageMock2, open("asdf")).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, blobs::OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
"asdf"));
EXPECT_FALSE(handler->commit(0, {}));
}
TEST_F(FirmwareHandlerCommitTest, VerifyCannotCommitOnHashFile)
{
/* Verify the hash file returns failure on this command. It's a fairly
* artificial test.
*/
/* Verify it doesn't get called by using StrictMock. */
std::unique_ptr<VerificationInterface> verifyMock =
std::make_unique<StrictMock<VerificationMock>>();
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
blobs, data, std::move(verifyMock), CreateUpdateMock());
EXPECT_CALL(imageMock1, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, blobs::OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
hashBlobId));
EXPECT_FALSE(handler->commit(0, {}));
}
TEST_F(FirmwareHandlerCommitTest, VerifyCommitAcceptedOnVerifyBlob)
{
/* Verify the verify blob lets you call this command, and it returns
* success.
*/
auto verifyMock = CreateVerifyMock();
auto verifyMockPtr = reinterpret_cast<VerificationMock*>(verifyMock.get());
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
blobs, data, std::move(verifyMock), CreateUpdateMock());
EXPECT_TRUE(handler->open(0, blobs::OpenFlags::write, verifyBlobId));
EXPECT_CALL(*verifyMockPtr, triggerVerification())
.WillRepeatedly(Return(true));
EXPECT_TRUE(handler->commit(0, {}));
}
TEST_F(FirmwareHandlerCommitTest, VerifyCommitCanOnlyBeCalledOnceForEffect)
{
/* Verify you cannot call the commit() command once verification is
* started, after which it will just return true.
*/
auto verifyMock = CreateVerifyMock();
auto verifyMockPtr = reinterpret_cast<VerificationMock*>(verifyMock.get());
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
blobs, data, std::move(verifyMock), CreateUpdateMock());
EXPECT_TRUE(handler->open(0, blobs::OpenFlags::write, verifyBlobId));
EXPECT_CALL(*verifyMockPtr, triggerVerification())
.WillRepeatedly(Return(true));
EXPECT_TRUE(handler->commit(0, {}));
EXPECT_TRUE(handler->commit(0, {}));
}
} // namespace ipmi_flash
|
