From a89f14e0f1c632393d4dc4bf4518de0b79976edc Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Mon, 14 Apr 2014 22:47:56 +0200 Subject: support/graphs: fix comparisons agains None As Samuel said: In Python, None is a singleton, and it is recommended to use "is" or "is not" for testing them [1]. [1] http://legacy.python.org/dev/peps/pep-0008/#programming-recommendations Reported-by: Samuel Martin Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Signed-off-by: Thomas Petazzoni --- support/scripts/graph-depends | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'support/scripts/graph-depends') diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends index 4f532ba142..e2a5e1ebf6 100755 --- a/support/scripts/graph-depends +++ b/support/scripts/graph-depends @@ -42,13 +42,13 @@ parser.add_argument("--depth", '-d', metavar="DEPTH", help="Limit the dependency graph to DEPTH levels") args = parser.parse_args() -if args.package == None: +if args.package is None: mode = FULL_MODE else: mode = PKG_MODE rootpkg = args.package -if args.depth != None: +if args.depth is not None: max_depth = int(args.depth) allpkgs = [] @@ -130,7 +130,7 @@ def get_all_depends(pkgs): if len(deps) != 0: newdeps = get_all_depends(deps) - if newdeps != None: + if newdeps is not None: dependencies += newdeps return dependencies @@ -202,7 +202,7 @@ if mode == FULL_MODE: dependencies.append(('all', tg)) filtered_targets.append(tg) deps = get_all_depends(filtered_targets) - if deps != None: + if deps is not None: dependencies += deps rootpkg = 'all' -- cgit v1.2.3