From a89f14e0f1c632393d4dc4bf4518de0b79976edc Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Mon, 14 Apr 2014 22:47:56 +0200 Subject: support/graphs: fix comparisons agains None As Samuel said: In Python, None is a singleton, and it is recommended to use "is" or "is not" for testing them [1]. [1] http://legacy.python.org/dev/peps/pep-0008/#programming-recommendations Reported-by: Samuel Martin Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Signed-off-by: Thomas Petazzoni --- support/scripts/graph-build-time | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'support/scripts/graph-build-time') diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time index 45f94353f3..8ef065f127 100755 --- a/support/scripts/graph-build-time +++ b/support/scripts/graph-build-time @@ -84,7 +84,7 @@ class Package: self.steps_duration[step] = self.steps_end[step] - self.steps_start[step] def get_duration(self, step=None): - if step == None: + if step is None: duration = 0 for step in self.steps_duration.keys(): duration += self.steps_duration[step] @@ -278,10 +278,10 @@ if args.alternate_colors: else: colors = default_colors -if args.type == "histogram" or args.type == None: +if args.type == "histogram" or args.type is None: if args.order == "build" or args.order == "duration" or args.order == "name": pkg_histogram(d, args.output, args.order) - elif args.order == None: + elif args.order is None: pkg_histogram(d, args.output, "name") else: sys.stderr.write("Unknown ordering: %s\n" % args.order) -- cgit v1.2.3