summaryrefslogtreecommitdiffstats
path: root/support/testing/tests
diff options
context:
space:
mode:
Diffstat (limited to 'support/testing/tests')
-rw-r--r--support/testing/tests/fs/test_ext.py9
-rw-r--r--support/testing/tests/toolchain/test_external.py6
2 files changed, 8 insertions, 7 deletions
diff --git a/support/testing/tests/fs/test_ext.py b/support/testing/tests/fs/test_ext.py
index f7e2e85055..ea3d3f11d7 100644
--- a/support/testing/tests/fs/test_ext.py
+++ b/support/testing/tests/fs/test_ext.py
@@ -21,10 +21,10 @@ def dumpe2fs_run(builddir, image):
return ret.strip().splitlines()
def dumpe2fs_getprop(out, prop):
- for lines in out:
- lines = lines.split(": ")
- if lines[0] == prop:
- return lines[1].strip()
+ for line in out:
+ fields = line.split(": ")
+ if fields[0] == prop:
+ return fields[1].strip()
def boot_img_and_check_fs_type(emulator, builddir, fs_type):
img = os.path.join(builddir, "images", "rootfs.{}".format(fs_type))
@@ -86,6 +86,7 @@ BR2_TARGET_ROOTFS_EXT2_3=y
out = dumpe2fs_run(self.builddir, "rootfs.ext3")
self.assertEqual(dumpe2fs_getprop(out, REVISION_PROP), "1 (dynamic)")
self.assertIn("has_journal", dumpe2fs_getprop(out, FEATURES_PROP))
+ self.assertNotIn("extent", dumpe2fs_getprop(out, FEATURES_PROP))
exit_code = boot_img_and_check_fs_type(self.emulator,
self.builddir, "ext3")
diff --git a/support/testing/tests/toolchain/test_external.py b/support/testing/tests/toolchain/test_external.py
index 1fbf81f8d3..0b15d489db 100644
--- a/support/testing/tests/toolchain/test_external.py
+++ b/support/testing/tests/toolchain/test_external.py
@@ -7,7 +7,7 @@ BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
"""
-def check_broken_links(path):
+def has_broken_links(path):
for root, dirs, files in os.walk(path):
for f in files:
fpath = os.path.join(root, f)
@@ -20,9 +20,9 @@ class TestExternalToolchain(infra.basetest.BRTest):
# Check for broken symlinks
for d in ["lib", "usr/lib"]:
path = os.path.join(self.builddir, "staging", d)
- self.assertFalse(check_broken_links(path))
+ self.assertFalse(has_broken_links(path))
path = os.path.join(self.builddir, "target", d)
- self.assertFalse(check_broken_links(path))
+ self.assertFalse(has_broken_links(path))
interp = infra.get_elf_prog_interpreter(self.builddir,
self.toolchain_prefix,
OpenPOWER on IntegriCloud